Bug 32661

Summary: Use template wrapper for invoices page tabs
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Katrin Fischer <katrin.fischer>
Severity: enhancement    
Priority: P5 - low CC: lucas, testopia
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.03
Bug Depends on: 32571    
Bug Blocks:    
Attachments: Bug 32661: Use template wrapper for invoices page tabs
Bug 32661: (follow-up) Use more unique variable name to avoid collisions
Bug 32661: Use template wrapper for invoices page tabs
Bug 32661: (follow-up) Use more unique variable name to avoid collisions
Bug 32661: Use template wrapper for invoices page tabs
Bug 32661: (follow-up) Use more unique variable name to avoid collisions

Description Owen Leonard 2023-01-17 20:19:16 UTC
Continuing the work of Bug 32571, the invoices template should be revised to use the new WRAPPER for tabs.
Comment 1 Owen Leonard 2023-01-17 20:40:12 UTC
Created attachment 145372 [details] [review]
Bug 32661: Use template wrapper for invoices page tabs

This patch implements the template WRAPPER system (see Bug 32571) for
building tabs on the invoices page.

To test you must have at least one open invoice and one closed invoice.

- Go to Acquisitions -> Invoices.
- You should see two tabs, "Open invoices" and "Closed invoices."
- The tabs should look correct and work correctly.
Comment 2 Owen Leonard 2023-01-20 16:30:49 UTC
Created attachment 145539 [details] [review]
Bug 32661: (follow-up) Use more unique variable name to avoid collisions
Comment 3 David Nind 2023-01-28 20:34:10 UTC
Created attachment 145792 [details] [review]
Bug 32661: Use template wrapper for invoices page tabs

This patch implements the template WRAPPER system (see Bug 32571) for
building tabs on the invoices page.

To test you must have at least one open invoice and one closed invoice.

- Go to Acquisitions -> Invoices.
- You should see two tabs, "Open invoices" and "Closed invoices."
- The tabs should look correct and work correctly.

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2023-01-28 20:34:15 UTC
Created attachment 145793 [details] [review]
Bug 32661: (follow-up) Use more unique variable name to avoid collisions

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 Katrin Fischer 2023-02-05 12:49:03 UTC
Created attachment 146206 [details] [review]
Bug 32661: Use template wrapper for invoices page tabs

This patch implements the template WRAPPER system (see Bug 32571) for
building tabs on the invoices page.

To test you must have at least one open invoice and one closed invoice.

- Go to Acquisitions -> Invoices.
- You should see two tabs, "Open invoices" and "Closed invoices."
- The tabs should look correct and work correctly.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Katrin Fischer 2023-02-05 12:49:07 UTC
Created attachment 146207 [details] [review]
Bug 32661: (follow-up) Use more unique variable name to avoid collisions

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 7 Tomás Cohen Arazi 2023-02-07 18:29:52 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 8 Jacob O'Mara 2023-02-08 16:53:34 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.