Bug 32673

Summary:	Remove misc/load_testing/ scripts
Product:	Koha	Reporter:	Jonathan Druart <jonathan.druart>
Component:	Test Suite	Assignee:	Jonathan Druart <jonathan.druart>
Status:	RESOLVED FIXED	QA Contact:	Marcel de Rooy <m.de.rooy>
Severity:	normal
Priority:	P5 - low	CC:	dcook, m.de.rooy
Version:	unspecified
Hardware:	All
OS:	All
See Also:	https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32664 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32654
Change sponsored?:	---	Patch complexity:	Trivial patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	23.05.00,22.11.03
Circulation function:
Attachments:	Bug 32673: Remove misc/load_testing/ scripts Bug 32673: Remove misc/load_testing/ scripts Bug 32673: Remove misc/load_testing/ scripts

Description Jonathan Druart 2023-01-18 13:30:47 UTC

We are spending too much time trying to package HTTPD::Bench::ApacheBench, and this dependency is only used by misc/load_testing scripts

I am not sure this is even used by anyone, and I didn't manage to make them work (just spent 5 min however):

$ perl misc/load_testing/benchmark_staff.pl --url=http://kohadev-intra.mydnsname.org:8081/cgi-bin/koha/ --user=koha --password=koha --steps=123456
Authentication successful
--------------
Koha STAFF benchmarking utility
--------------
Benchmarking with 20 occurrences of each operation and 30 concurrent sessions 
Step 1: staff interface main page       36ms    555.555 pages/sec
Step 2: catalog detail page             34ms    588.235 biblios/sec
Step 3: catalogue search                35ms    571.428 biblios/sec
Step 4: patron detail page              28ms    714.285 borrowers/sec
Step 5: patron search page              69ms    579.71 borrowers/sec
Step 6a circulation (checkouts)         35ms    571.428 checkouts/sec
Step 6b circulation (checkins)          36ms    555.555 checkins/sec
Skipping 'testing all transactions at once'

That does not seems correct (too fast).

Moreover D12 is currently failing (00-strict.t because of missing deps)

Mason did the work but it's not there yet: https://salsa.debian.org/perl-team/modules/packages/libhttpd-bench-apachebench-perl

What do we want? I would vote for removing the script and the dependency.

Comment 1 Jonathan Druart 2023-01-18 13:32:58 UTC

Created attachment 145393 [details] [review]
Bug 32673: Remove misc/load_testing/ scripts

see comment 0 for more info

Comment 2 David Cook 2023-01-22 23:19:36 UTC

+1 for removing. I've never ever used those scripts.

Comment 3 David Cook 2023-02-02 04:33:42 UTC

Created attachment 145990 [details] [review]
Bug 32673: Remove misc/load_testing/ scripts

see comment 0 for more info

Signed-off-by: David Cook <dcook@prosentient.com.au>

Comment 4 Marcel de Rooy 2023-02-03 10:48:17 UTC

Created attachment 146069 [details] [review]
Bug 32673: Remove misc/load_testing/ scripts

see comment 0 for more info

Signed-off-by: David Cook <dcook@prosentient.com.au>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Comment 5 Tomás Cohen Arazi (tcohen) 2023-02-03 13:33:18 UTC

Pushed to master for 23.05.

Nice work everyone, thanks!

Comment 6 Jacob O'Mara 2023-02-06 15:58:35 UTC

Nice work, thanks everyone!

Pushed to 22.11.x for the next release.