Summary: | Add new line in authorized values tests in search_for_data_inconsistencies.pl | ||
---|---|---|---|
Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
Component: | Architecture, internals, and plumbing | Assignee: | Fridolin Somers <fridolin.somers> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | arthur.suzuki, jonathan.druart, lucas, nick, wainuiwitikapark |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.04,22.05.11,21.11.19
|
|
Circulation function: | |||
Attachments: |
Bug 32678: Add new line in authorized values tests in search_for_data_inconsistencies.pl
Bug 32678: Add new line in authorized values tests in search_for_data_inconsistencies.pl Bug 32678: Add new line in authorized values tests in search_for_data_inconsistencies.pl |
Description
Fridolin Somers
2023-01-19 07:12:12 UTC
Created attachment 145455 [details] [review] Bug 32678: Add new line in authorized values tests in search_for_data_inconsistencies.pl In search_for_data_inconsistencies.pl, the test for authorized values is a list in one line : * The Framework *VR* is using the authorised value's category *LOC*, but the following items.location do not have a value defined ({itemnumber => value }): {94 => AV} {95 => AV} {96 => AV} {97 => AV} {98 => AV} {99 => AV} {100 => AV} {101 => AV} {102 => AV} {103 => AV} It would be more clear with new lines, especially for scripts (grep, awk ...) : * The Framework *VR* is using the authorised value's category *LOC*, but the following items.location do not have a value defined ({itemnumber => value }): {94 => AV} {95 => AV} {96 => AV} {97 => AV} {98 => AV} {99 => AV} {100 => AV} {101 => AV} {102 => AV} {103 => AV} Test plan : 1) In koha-testing-docker 2) Delete in authorized values LOC the value AV 3) Run misc/maintenance/search_for_data_inconsistencies.pl => You see the new line in result Created attachment 145706 [details] [review] Bug 32678: Add new line in authorized values tests in search_for_data_inconsistencies.pl In search_for_data_inconsistencies.pl, the test for authorized values is a list in one line : * The Framework *VR* is using the authorised value's category *LOC*, but the following items.location do not have a value defined ({itemnumber => value }): {94 => AV} {95 => AV} {96 => AV} {97 => AV} {98 => AV} {99 => AV} {100 => AV} {101 => AV} {102 => AV} {103 => AV} It would be more clear with new lines, especially for scripts (grep, awk ...) : * The Framework *VR* is using the authorised value's category *LOC*, but the following items.location do not have a value defined ({itemnumber => value }): {94 => AV} {95 => AV} {96 => AV} {97 => AV} {98 => AV} {99 => AV} {100 => AV} {101 => AV} {102 => AV} {103 => AV} Test plan : 1) In koha-testing-docker 2) Delete in authorized values LOC the value AV 3) Run misc/maintenance/search_for_data_inconsistencies.pl => You see the new line in result Signed-off-by: David Nind <david@davidnind.com> The condensed output was expected, in case there are thousands to output. Letting somebody else decides. Created attachment 147726 [details] [review] Bug 32678: Add new line in authorized values tests in search_for_data_inconsistencies.pl In search_for_data_inconsistencies.pl, the test for authorized values is a list in one line : * The Framework *VR* is using the authorised value's category *LOC*, but the following items.location do not have a value defined ({itemnumber => value }): {94 => AV} {95 => AV} {96 => AV} {97 => AV} {98 => AV} {99 => AV} {100 => AV} {101 => AV} {102 => AV} {103 => AV} It would be more clear with new lines, especially for scripts (grep, awk ...) : * The Framework *VR* is using the authorised value's category *LOC*, but the following items.location do not have a value defined ({itemnumber => value }): {94 => AV} {95 => AV} {96 => AV} {97 => AV} {98 => AV} {99 => AV} {100 => AV} {101 => AV} {102 => AV} {103 => AV} Test plan : 1) In koha-testing-docker 2) Delete in authorized values LOC the value AV 3) Run misc/maintenance/search_for_data_inconsistencies.pl => You see the new line in result Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> (In reply to Jonathan Druart from comment #3) > The condensed output was expected, in case there are thousands to output. > > Letting somebody else decides. I do think it's friendlier - kicking to RM for final say Pushed to master for 23.05. Nice work everyone, thanks! Nice work, thanks everyone! Pushed to 22.11.x for the next release. Backported to 22.05.x for upcoming 22.05.11 applied to 21.11 for 21.11.19 Not backported to 21.05.x |