Summary: | CSS class article-request-title is doubled up in article requests list in staff patron account | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | OPAC | Assignee: | Katrin Fischer <katrin.fischer> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | arthur.suzuki, lucas, martin.renvoize, wainuiwitikapark |
Version: | Main | Keywords: | Academy |
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.04,22.05.11,21.11.19
|
|
Circulation function: | |||
Attachments: |
Bug 32679: Use different CSS classes for titles of article requests in staff interface
Bug 32679: Use different CSS classes for titles of article requests in staff interface Bug 32679: Use different CSS classes for titles of article requests in staff interface |
Description
Katrin Fischer
2023-01-19 08:10:57 UTC
This is already fixed in master on the OPAC side: <td class="article-request-record-title"> [% INCLUDE 'biblio-title.inc' biblio=ar.biblio link=> 1 %] Created attachment 145511 [details] [review] Bug 32679: Use different CSS classes for titles of article requests in staff interface The class article-request-title was used for the column with the article title as well as for the link with the record title. This could cause some confusion when changing the table with CSS. This patch makes it so different CSS classes are used for each. To test: * Activate article requests in system preferences * Make sure circulation conditions have article requets = yes * Create an article request in staff or OPAC * View the list of article requests in the patron account in staff * Add the following line to IntranetUserCSS: .article-request-title { display:none; } * Verify the Title column and the title from Record title (first column) have vanished. * Apply patch: now only the column should vanish, Record title shoudl remain visible * If you want: Verify that the record title has a differently named class now. Note: I pondered also using biblio-title.inc here, but in the patron account the title links to the article request page and not to the detail page. I didn't find a way to do that using the include. Created attachment 145515 [details] [review] Bug 32679: Use different CSS classes for titles of article requests in staff interface The class article-request-title was used for the column with the article title as well as for the link with the record title. This could cause some confusion when changing the table with CSS. This patch makes it so different CSS classes are used for each. To test: * Activate article requests in system preferences * Make sure circulation conditions have article requets = yes * Create an article request in staff or OPAC * View the list of article requests in the patron account in staff * Add the following line to IntranetUserCSS: .article-request-title { display:none; } * Verify the Title column and the title from Record title (first column) have vanished. * Apply patch: now only the column should vanish, Record title shoudl remain visible * If you want: Verify that the record title has a differently named class now. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 147216 [details] [review] Bug 32679: Use different CSS classes for titles of article requests in staff interface The class article-request-title was used for the column with the article title as well as for the link with the record title. This could cause some confusion when changing the table with CSS. This patch makes it so different CSS classes are used for each. To test: * Activate article requests in system preferences * Make sure circulation conditions have article requets = yes * Create an article request in staff or OPAC * View the list of article requests in the patron account in staff * Add the following line to IntranetUserCSS: .article-request-title { display:none; } * Verify the Title column and the title from Record title (first column) have vanished. * Apply patch: now only the column should vanish, Record title shoudl remain visible * If you want: Verify that the record title has a differently named class now. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 23.05. Nice work everyone, thanks! Nice work everyone! Pushed to stable for 22.11.x Backpoprted to 22.05.x for upcoming 22.05.11 applied to 21.11 for 21.11.19 Not backported to 21.05.x |