Summary: | Reindent the serial collection template | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | minor | ||
Priority: | P5 - low | CC: | lucas, martin.renvoize, testopia |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.03
|
|
Circulation function: | |||
Attachments: |
Bug 32690: Reindent the serial collection template
Bug 32690: (follow-up) Add markup comments Bug 32690: Reindent the serial collection template Bug 32690: (follow-up) Add markup comments Bug 32690: Reindent the serial collection template Bug 32690: (follow-up) Add markup comments |
Description
Owen Leonard
2023-01-20 16:59:30 UTC
Created attachment 145543 [details] [review] Bug 32690: Reindent the serial collection template This patch reindents the serial collection template so that it has consistent indentation. These changes should have no visible effect on the page. To test, apply the patch and go to Serials -> Subscription detail -> Serial collection. Everything should look normal. All tabs should work correctly. Viewing the diff while ignoring whitespace changes should show only places where a line break was added. Created attachment 145544 [details] [review] Bug 32690: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Created attachment 145774 [details] [review] Bug 32690: Reindent the serial collection template This patch reindents the serial collection template so that it has consistent indentation. These changes should have no visible effect on the page. To test, apply the patch and go to Serials -> Subscription detail -> Serial collection. Everything should look normal. All tabs should work correctly. Viewing the diff while ignoring whitespace changes should show only places where a line break was added. Signed-off-by: David Nind <david@davidnind.com> Created attachment 145775 [details] [review] Bug 32690: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: David Nind <david@davidnind.com> Created attachment 145817 [details] [review] Bug 32690: Reindent the serial collection template This patch reindents the serial collection template so that it has consistent indentation. These changes should have no visible effect on the page. To test, apply the patch and go to Serials -> Subscription detail -> Serial collection. Everything should look normal. All tabs should work correctly. Viewing the diff while ignoring whitespace changes should show only places where a line break was added. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 145818 [details] [review] Bug 32690: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.05. Nice work everyone, thanks! Nice work, thanks everyone! Pushed to 22.11.x for the next release. Doesn't apply cleanly to 22.05.x, no backport |