Summary: | Self checkout help page lacks required I18N JavaScript | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | OPAC | Assignee: | Katrin Fischer <katrin.fischer> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | danyonsewell, david, jonathan.druart, lucas |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32672 | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.06,22.05.14
|
|
Circulation function: | |||
Bug Depends on: | 28488 | ||
Bug Blocks: | |||
Attachments: |
Bug 32701: Fix I18N JavaScript libraries on self checkout help page
Bug 32701: Fix I18N JavaScript libraries on self checkout help page Bug 32701: Fix I18N JavaScript libraries on self checkout help page |
Description
Owen Leonard
2023-01-23 15:11:46 UTC
Created attachment 150137 [details] [review] Bug 32701: Fix I18N JavaScript libraries on self checkout help page The help page was missing the fixes from bug 28488. The missing libraries are causing a JavaScript error on the page and likely other issues. To test: * Make sure WebBasedSelfCheck is activated and configured Note: In ktd you don't need to configure anything, it's already set up. * In the OPAC, go to: /cgi-bin/koha/sco/sco-main.pl * Click on the link to the help in the top right corner * Verify you see the error in the console: jQuery.Deferred exception: __ is not defined * Apply patch * Restart things * Reload the page * Veriy the errors are gone Created attachment 150145 [details] [review] Bug 32701: Fix I18N JavaScript libraries on self checkout help page The help page was missing the fixes from bug 28488. The missing libraries are causing a JavaScript error on the page and likely other issues. To test: * Make sure WebBasedSelfCheck is activated and configured Note: In ktd you don't need to configure anything, it's already set up. * In the OPAC, go to: /cgi-bin/koha/sco/sco-main.pl * Click on the link to the help in the top right corner * Verify you see the error in the console: jQuery.Deferred exception: __ is not defined * Apply patch * Restart things * Reload the page * Veriy the errors are gone Signed-off-by: David Nind <david@davidnind.com> Created attachment 150211 [details] [review] Bug 32701: Fix I18N JavaScript libraries on self checkout help page The help page was missing the fixes from bug 28488. The missing libraries are causing a JavaScript error on the page and likely other issues. To test: * Make sure WebBasedSelfCheck is activated and configured Note: In ktd you don't need to configure anything, it's already set up. * In the OPAC, go to: /cgi-bin/koha/sco/sco-main.pl * Click on the link to the help in the top right corner * Verify you see the error in the console: jQuery.Deferred exception: __ is not defined * Apply patch * Restart things * Reload the page * Veriy the errors are gone Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> It does not make sense to have it here, but I am lazy to find a better solution (and it's already in sci-main). Pushed to master for 23.05. Nice work everyone, thanks! Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release Backported to 22.05.x for upcoming 22.05.14 Does this need to be backported to 21.11.x? |