Summary: | Background job UI and REST API routes explode if JSON is incorrect | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Staff interface | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | In Discussion --- | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | dcook, gmcharlt, m.de.rooy, martin.renvoize, nick, tomascohen |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 32393 | ||
Bug Blocks: | |||
Attachments: | Bug 32709: Prevent REST API and UI to crash if job has incorrect JSON |
Description
Jonathan Druart
2023-01-24 11:21:52 UTC
Created attachment 145607 [details] [review] Bug 32709: Prevent REST API and UI to crash if job has incorrect JSON Same as bug 32393, but for the REST API routes and the UI. Test plan: Enqueue a job with an incorrect JSON string in the data column Go to the background jobs list and the detail views Confirm that no the page does not explodes Notice the warning on the detail page I think we need that. However I am not sure how to deal with logging. With this patch we are logging 4 times the same "Cannot decode data for background job id=" error, how could we do better? This patch also needs tests. |