Description
Katrin Fischer
2023-01-30 17:13:57 UTC
Created attachment 148320 [details] [review] Bug 32752: Use an include for displaying the serial status in the OPAC This moves the existing status in the OPAC into an include. To test: * Add a subscription with issues in different status * View the OPAC detail page of the record * Verify that in the subscription tab the status display nicely * Veriy that More details > Full history displays the status nicely too Created attachment 148321 [details] [review] Bug 32752: Use an include to display the serial status in the staff interface This moves the identical code used to display the serial status from the different templates into one common include. To test: * Add a subscription * Receive several issues, make sure 2 are late * Claim one of the late issues * Verify the status displays nicely on these pages: * Subscription detail page > issues tab * Catalog detail page > subscription tab * Serial claims page * Serial collection page of your subscription Note: there was some code for the subscription detail page that should have displayed the claim date, but didn't work. To keep things simpler and identical to before, I have left that bit out for now. Created attachment 148322 [details] [review] Bug 32752: Add new status Circulationg, Out for binding, and Bound to includes To test with the next patch that allows to set the new status. Created attachment 148323 [details] [review] Bug 32752: Update serial edit form to allow for new status With this patch the new status Circulating, Out for binding and Bound can be set for any issue, if the current status is "Arrived". This is to keep the list a little shorter when the issue hasn't even arrived in the library yet. These new status will be especially helpful if the library has opted to not create items for all their subscriptions as a lot of libraries will only lend bound volumes, but not the singular issues. * Circulating: this will be useful if the library is using routing lists and the items are not available at the library for a longer time. * Out for binding: if you send out issues for binding this will help to track these. * Bound: this will help users to know that the issue is now available as a bound volume. To test: * If you haven't yet: * Create a subscription * From the serial collection page: * Receive or create several issues and set different status * Make sure you have at least 2 late and claim one of them * Make sure you have several Arrived issues * Edit Arrived serial issues and others * Verify that the status pull down no also shows the new status if the issue has already Arrived * Set the new status * Verify they save and show correctly * Edit again and verify the pull downs are pre-set correctly to the saved status * Verify they show everywhere else (see previous test plans :) ) Created attachment 148353 [details] [review] Bug 32752: Use an include for displaying the serial status in the OPAC This moves the existing status in the OPAC into an include. To test: * Add a subscription with issues in different status * View the OPAC detail page of the record * Verify that in the subscription tab the status display nicely * Veriy that More details > Full history displays the status nicely too Created attachment 148354 [details] [review] Bug 32752: Use an include to display the serial status in the staff interface This moves the identical code used to display the serial status from the different templates into one common include. To test: * Add a subscription * Receive several issues, make sure 2 are late * Claim one of the late issues * Verify the status displays nicely on these pages: * Subscription detail page > issues tab * Catalog detail page > subscription tab * Serial claims page * Serial collection page of your subscription Note: there was some code for the subscription detail page that should have displayed the claim date, but didn't work. To keep things simpler and identical to before, I have left that bit out for now. Created attachment 148355 [details] [review] Bug 32752: Add new status Circulationg, Out for binding, and Bound to includes To test with the next patch that allows to set the new status. Created attachment 148356 [details] [review] Bug 32752: Update serial edit form to allow for new status With this patch the new status Circulating, Out for binding and Bound can be set for any issue, if the current status is not "Expected". This is to keep the list a little shorter when the issue hasn't even arrived in the library yet. These new status will be especially helpful if the library has opted to not create items for all their subscriptions as a lot of libraries will only lend bound volumes, but not the singular issues. * Circulating: this will be useful if the library is using routing lists and the items are not available at the library for a longer time. * Out for binding: if you send out issues for binding this will help to track these. * Bound: this will help users to know that the issue is now available as a bound volume. To test: * If you haven't yet: * Create a subscription * From the serial collection page: * Receive or create several issues and set different status * Make sure you have at least 2 late and claim one of them * Make sure you have several Arrived issues * Edit Arrived serial issues and others * Verify that the status pull down no also shows the new status if the issue has already Arrived * Set the new status * Verify they save and show correctly * Edit again and verify the pull downs are pre-set correctly to the saved status * Verify they show everywhere else (see previous test plans :) ) Created attachment 148357 [details] [review] Bug 32752: Use an include for displaying the serial status in the OPAC This moves the existing status in the OPAC into an include. To test: * Add a subscription with issues in different status * View the OPAC detail page of the record * Verify that in the subscription tab the status display nicely * Veriy that More details > Full history displays the status nicely too Created attachment 148358 [details] [review] Bug 32752: Use an include to display the serial status in the staff interface This moves the identical code used to display the serial status from the different templates into one common include. To test: * Add a subscription * Receive several issues, make sure 2 are late * Claim one of the late issues * Verify the status displays nicely on these pages: * Subscription detail page > issues tab * Catalog detail page > subscription tab * Serial claims page * Serial collection page of your subscription Note: there was some code for the subscription detail page that should have displayed the claim date, but didn't work. To keep things simpler and identical to before, I have left that bit out for now. Created attachment 148359 [details] [review] Bug 32752: Add new status Circulationg, Out for binding, and Bound to includes To test with the next patch that allows to set the new status. Created attachment 148360 [details] [review] Bug 32752: Update serial edit form to allow for new status With this patch the new status Circulating, Out for binding and Bound can be set for any issue, if the current status is not "Expected". This is to keep the list a little shorter when the issue hasn't even arrived in the library yet. These new status will be especially helpful if the library has opted to not create items for all their subscriptions as a lot of libraries will only lend bound volumes, but not the singular issues. * Circulating: this will be useful if the library is using routing lists and the items are not available at the library for a longer time. * Out for binding: if you send out issues for binding this will help to track these. * Bound: this will help users to know that the issue is now available as a bound volume. To test: * If you haven't yet: * Create a subscription * From the serial collection page: * Receive or create several issues and set different status * Make sure you have at least 2 late and claim one of them * Make sure you have several Arrived issues * Edit Arrived serial issues and others * Verify that the status pull down no also shows the new status if the issue has a different status than "Expected" * Set the new status * Verify they save and show correctly * Edit again and verify the pull downs are pre-set correctly to the saved status * Verify they show everywhere else (see previous test plans :) ) Created attachment 148362 [details] [review] Bug 32752: Use an include for displaying the serial status in the OPAC This moves the existing status in the OPAC into an include. To test: * Add a subscription with issues in different status * View the OPAC detail page of the record * Verify that in the subscription tab the status display nicely * Veriy that More details > Full history displays the status nicely too Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Created attachment 148363 [details] [review] Bug 32752: Use an include to display the serial status in the staff interface This moves the identical code used to display the serial status from the different templates into one common include. To test: * Add a subscription * Receive several issues, make sure 2 are late * Claim one of the late issues * Verify the status displays nicely on these pages: * Subscription detail page > issues tab * Catalog detail page > subscription tab * Serial claims page * Serial collection page of your subscription Note: there was some code for the subscription detail page that should have displayed the claim date, but didn't work. To keep things simpler and identical to before, I have left that bit out for now. Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Created attachment 148364 [details] [review] Bug 32752: Add new status Circulationg, Out for binding, and Bound to includes To test with the next patch that allows to set the new status. Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Created attachment 148365 [details] [review] Bug 32752: Update serial edit form to allow for new status With this patch the new status Circulating, Out for binding and Bound can be set for any issue, if the current status is not "Expected". This is to keep the list a little shorter when the issue hasn't even arrived in the library yet. These new status will be especially helpful if the library has opted to not create items for all their subscriptions as a lot of libraries will only lend bound volumes, but not the singular issues. * Circulating: this will be useful if the library is using routing lists and the items are not available at the library for a longer time. * Out for binding: if you send out issues for binding this will help to track these. * Bound: this will help users to know that the issue is now available as a bound volume. To test: * If you haven't yet: * Create a subscription * From the serial collection page: * Receive or create several issues and set different status * Make sure you have at least 2 late and claim one of them * Make sure you have several Arrived issues * Edit Arrived serial issues and others * Verify that the status pull down no also shows the new status if the issue has a different status than "Expected" * Set the new status * Verify they save and show correctly * Edit again and verify the pull downs are pre-set correctly to the saved status * Verify they show everywhere else (see previous test plans :) ) Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Created attachment 148366 [details] [review] Bug 32752: Use an include for displaying the serial status in the OPAC This moves the existing status in the OPAC into an include. To test: * Add a subscription with issues in different status * View the OPAC detail page of the record * Verify that in the subscription tab the status display nicely * Veriy that More details > Full history displays the status nicely too Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Created attachment 148367 [details] [review] Bug 32752: Use an include to display the serial status in the staff interface This moves the identical code used to display the serial status from the different templates into one common include. To test: * Add a subscription * Receive several issues, make sure 2 are late * Claim one of the late issues * Verify the status displays nicely on these pages: * Subscription detail page > issues tab * Catalog detail page > subscription tab * Serial claims page * Serial collection page of your subscription Note: there was some code for the subscription detail page that should have displayed the claim date, but didn't work. To keep things simpler and identical to before, I have left that bit out for now. Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Created attachment 148368 [details] [review] Bug 32752: Add new status Circulating, Out for binding, and Bound to includes To test with the next patch that allows to set the new status. Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Created attachment 148369 [details] [review] Bug 32752: Update serial edit form to allow for new status With this patch the new status Circulating, Out for binding and Bound can be set for any issue, if the current status is not "Expected". This is to keep the list a little shorter when the issue hasn't even arrived in the library yet. These new status will be especially helpful if the library has opted to not create items for all their subscriptions as a lot of libraries will only lend bound volumes, but not the singular issues. * Circulating: this will be useful if the library is using routing lists and the items are not available at the library for a longer time. * Out for binding: if you send out issues for binding this will help to track these. * Bound: this will help users to know that the issue is now available as a bound volume. To test: * If you haven't yet: * Create a subscription * From the serial collection page: * Receive or create several issues and set different status * Make sure you have at least 2 late issues and claim one of them * Edit Arrived serial issues and others * Verify that the status pull down no also shows the new status if the issue has a different status than "Expected" * Set the new status * Verify they save and show correctly * Edit again and verify the pull downs are pre-set correctly to the saved status * Verify they show everywhere else (see previous test plans :) ) Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Fixed a mistake in the test plan and a typo in the commit message, no changes to the code. Created attachment 148370 [details] [review] Bug 32752: Use an include for displaying the serial status in the OPAC This moves the existing status in the OPAC into an include. To test: * Add a subscription with issues in different status * View the OPAC detail page of the record * Verify that in the subscription tab the status display nicely * Veriy that More details > Full history displays the status nicely too Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Created attachment 148371 [details] [review] Bug 32752: Use an include to display the serial status in the staff interface This moves the identical code used to display the serial status from the different templates into one common include. To test: * Add a subscription * Receive several issues, make sure 2 are late * Claim one of the late issues * Verify the status displays nicely on these pages: * Subscription detail page > issues tab * Catalog detail page > subscription tab * Serial claims page * Serial collection page of your subscription Note: there was some code for the subscription detail page that should have displayed the claim date, but didn't work. To keep things simpler and identical to before, I have left that bit out for now. Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Created attachment 148372 [details] [review] Bug 32752: Add new status Circulating, Out for binding, and Bound to includes To test with the next patch that allows to set the new status. Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Created attachment 148373 [details] [review] Bug 32752: Update serial edit form to allow for new status With this patch the new status Circulating, Out for binding and Bound can be set for any issue, if the current status is not "Expected". This is to keep the list a little shorter when the issue hasn't even arrived in the library yet. These new status will be especially helpful if the library has opted to not create items for all their subscriptions as a lot of libraries will only lend bound volumes, but not the singular issues. * Circulating: this will be useful if the library is using routing lists and the items are not available at the library for a longer time. * Out for binding: if you send out issues for binding this will help to track these. * Bound: this will help users to know that the issue is now available as a bound volume. To test: * If you haven't yet: * Create a subscription * From the serial collection page: * Receive or create several issues and set different status * Make sure you have at least 2 late issues and claim one of them * Edit Arrived serial issues and others * Verify that the status pull down no also shows the new status if the issue has a different status than "Expected" * Set the new status * Verify they save and show correctly * Edit again and verify the pull downs are pre-set correctly to the saved status * Verify they show everywhere else (see previous test plans :) ) Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Created attachment 148490 [details] [review] Bug 32752: Update serial edit form to allow for new status With this patch the new status Circulating, Out for binding and Bound can be set for any issue, if the current status is not "Expected". This is to keep the list a little shorter when the issue hasn't even arrived in the library yet. These new status will be especially helpful if the library has opted to not create items for all their subscriptions as a lot of libraries will only lend bound volumes, but not the singular issues. * Circulating: this will be useful if the library is using routing lists and the items are not available at the library for a longer time. * Out for binding: if you send out issues for binding this will help to track these. * Bound: this will help users to know that the issue is now available as a bound volume. To test: * If you haven't yet: * Create a subscription * From the serial collection page: * Receive or create several issues and set different status * Make sure you have at least 2 late and claim one of them * Make sure you have several Arrived issues * Edit Arrived serial issues and others * Verify that the status pull down no also shows the new status if the issue has a different status than "Expected" * Set the new status * Verify they save and show correctly * Edit again and verify the pull downs are pre-set correctly to the saved status * Verify they show everywhere else (see previous test plans :) ) Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Works as described. The template changes look good. Checked all the HTML and everything is valid. QA scripts are happy. Nice enhancement. Created attachment 150051 [details] [review] Bug 32752: Use an include for displaying the serial status in the OPAC This moves the existing status in the OPAC into an include. To test: * Add a subscription with issues in different status * View the OPAC detail page of the record * Verify that in the subscription tab the status display nicely * Veriy that More details > Full history displays the status nicely too Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 150052 [details] [review] Bug 32752: Use an include to display the serial status in the staff interface This moves the identical code used to display the serial status from the different templates into one common include. To test: * Add a subscription * Receive several issues, make sure 2 are late * Claim one of the late issues * Verify the status displays nicely on these pages: * Subscription detail page > issues tab * Catalog detail page > subscription tab * Serial claims page * Serial collection page of your subscription Note: there was some code for the subscription detail page that should have displayed the claim date, but didn't work. To keep things simpler and identical to before, I have left that bit out for now. Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 150053 [details] [review] Bug 32752: Add new status Circulating, Out for binding, and Bound to includes To test with the next patch that allows to set the new status. Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 150054 [details] [review] Bug 32752: Update serial edit form to allow for new status With this patch the new status Circulating, Out for binding and Bound can be set for any issue, if the current status is not "Expected". This is to keep the list a little shorter when the issue hasn't even arrived in the library yet. These new status will be especially helpful if the library has opted to not create items for all their subscriptions as a lot of libraries will only lend bound volumes, but not the singular issues. * Circulating: this will be useful if the library is using routing lists and the items are not available at the library for a longer time. * Out for binding: if you send out issues for binding this will help to track these. * Bound: this will help users to know that the issue is now available as a bound volume. To test: * If you haven't yet: * Create a subscription * From the serial collection page: * Receive or create several issues and set different status * Make sure you have at least 2 late and claim one of them * Make sure you have several Arrived issues * Edit Arrived serial issues and others * Verify that the status pull down no also shows the new status if the issue has a different status than "Expected" * Set the new status * Verify they save and show correctly * Edit again and verify the pull downs are pre-set correctly to the saved status * Verify they show everywhere else (see previous test plans :) ) Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Thanks a lot! Pushed to master for 23.05. Nice work everyone, thanks! Enhancement - not backporting to 22.11.x *** Bug 12187 has been marked as a duplicate of this bug. *** |