Summary: | Curbside pickups - Order curbside pickup slots chronologically | ||
---|---|---|---|
Product: | Koha | Reporter: | Caroline Cyr La Rose <caroline.cyr-la-rose> |
Component: | System Administration | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
Severity: | minor | ||
Priority: | P5 - low | CC: | gmcharlt, jonathan.druart, lucas, martin.renvoize |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.03
|
|
Circulation function: | |||
Bug Depends on: | 30650 | ||
Bug Blocks: | |||
Attachments: |
Bug 32788: Order curbside pickup slots chronologically
Bug 32788: Order curbside pickup slots chronologically Bug 32788: Order curbside pickup slots chronologically |
Description
Caroline Cyr La Rose
2023-02-01 20:42:54 UTC
I noticed that the order also affects the way the slots are displayed when scheduling a pickup. If your day looks like 13-16, 10-12 in the configuration, the slots will be in that order too in the Schedule pickup tab in Circulation Created attachment 146285 [details] [review] Bug 32788: Order curbside pickup slots chronologically We need to order the slots chronologically, not depending on when they have been added. Test plan: Create a slot 13 to 17 the another one 8 to 12 We want to display 8 to 12 before 13 to 17. Confirm that this patch fixes that on the 3 following views: Curbside pickups admin Curbside pickups staff side Curbside pickups at the OPAC Created attachment 146291 [details] [review] Bug 32788: Order curbside pickup slots chronologically We need to order the slots chronologically, not depending on when they have been added. Test plan: Create a slot 13 to 17 the another one 8 to 12 We want to display 8 to 12 before 13 to 17. Confirm that this patch fixes that on the 3 following views: Curbside pickups admin Curbside pickups staff side Curbside pickups at the OPAC Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Thanks Jonathan! Created attachment 146327 [details] [review] Bug 32788: Order curbside pickup slots chronologically We need to order the slots chronologically, not depending on when they have been added. Test plan: Create a slot 13 to 17 the another one 8 to 12 We want to display 8 to 12 before 13 to 17. Confirm that this patch fixes that on the 3 following views: Curbside pickups admin Curbside pickups staff side Curbside pickups at the OPAC Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Nice improvement, no regressions found. PQA Pushed to master for 23.05. Nice work everyone, thanks! Nice work everyone! Pushed to 22.11.x for next release Missing dependencies for 22.05.x, no backport. |