| Summary: | Cannot save OAI set mapping rule for subfield 0 | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | Staff interface | Assignee: | Nick Clemens (kidclamp) <nick> |
| Status: | RESOLVED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | arthur.suzuki, gmcharlt, lucas, m.de.rooy, wainuiwitikapark |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.03,22.05.10,21.11.16
|
|
| Circulation function: | |||
| Attachments: |
Bug 32797: Check if fields have a value, not if true
Bug 32797: Check if fields have a value, not if true Bug 32797: Check if fields have a value, not if true |
||
|
Description
Nick Clemens (kidclamp)
2023-02-02 14:56:50 UTC
Created attachment 146011 [details] [review] Bug 32797: Check if fields have a value, not if true When saving OAI set mappgins we are checking for truth, this prevents saving subfield 0. We should check for content To test: 1 - Go to Admin->OAI sets 2 - Create a set 3 - Define mappings for the set 4 - Attempt to save a rule on field 952 subfield 0 (withdrawn) 5 - It does not save 6 - Apply patch 7 - Try again 8 - Success! Created attachment 146029 [details] [review] Bug 32797: Check if fields have a value, not if true When saving OAI set mappgins we are checking for truth, this prevents saving subfield 0. We should check for content To test: 1 - Go to Admin->OAI sets 2 - Create a set 3 - Define mappings for the set 4 - Attempt to save a rule on field 952 subfield 0 (withdrawn) 5 - It does not save 6 - Apply patch 7 - Try again 8 - Success! Signed-off-by: David Nind <david@davidnind.com> Created attachment 146059 [details] [review] Bug 32797: Check if fields have a value, not if true When saving OAI set mappgins we are checking for truth, this prevents saving subfield 0. We should check for content To test: 1 - Go to Admin->OAI sets 2 - Create a set 3 - Define mappings for the set 4 - Attempt to save a rule on field 952 subfield 0 (withdrawn) 5 - It does not save 6 - Apply patch 7 - Try again 8 - Success! Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master for 23.05. Nice work everyone, thanks! Nice work, thanks everyone! Pushed to 22.11.x for the next release. Backported to 22.05.x for upcoming 22.05.10 applied to 21.11.x for 21.11.16 Not backported to 21.05.x |