Summary: | When recording localuse in the statistics table location is always NULL | ||
---|---|---|---|
Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
Component: | Reports | Assignee: | Lucas Gass (lukeg) <lucas> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | jonathan.druart |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.04
|
|
Circulation function: | |||
Attachments: |
Bug 32805: Update location when recording a localuse in statistics table
Bug 32805: Update location when recording a localuse in statistics table Bug 32805: Add tests Bug 32805: Update location when recording a localuse in statistics table Bug 32805: Add tests |
Description
Lucas Gass (lukeg)
2023-02-02 19:07:09 UTC
Created attachment 146024 [details] [review] Bug 32805: Update location when recording a localuse in statistics table To test: 1. Create a statistical patron and checkout, checkin to them. 2. Notice in the statistics table that the location is NULL 3. Apply patch 4. Try steps 1-2 again 5. The location should be correctly recorded in statistics.location Created attachment 146158 [details] [review] Bug 32805: Update location when recording a localuse in statistics table To test: 1. Create a statistical patron and checkout, checkin to them. 2. Notice in the statistics table that the location is NULL 3. Apply patch 4. Try steps 1-2 again 5. The location should be correctly recorded in statistics.location Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> This change needs a test. Created attachment 147249 [details] [review] Bug 32805: Add tests (In reply to Jonathan Druart from comment #3) > This change needs a test. Added tests and setting status back to 'Signed-off' Created attachment 147256 [details] [review] Bug 32805: Update location when recording a localuse in statistics table To test: 1. Create a statistical patron and checkout, checkin to them. 2. Notice in the statistics table that the location is NULL 3. Apply patch 4. Try steps 1-2 again 5. The location should be correctly recorded in statistics.location Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 147257 [details] [review] Bug 32805: Add tests JD amended patch: tidy Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 23.05. Nice work everyone, thanks! Nice work everyone! Pushed to stable for 22.11.x Doesn't apply to 22.05.x, no backport. |