Bug 32815

Summary: Fix cataloguing/value_builder/callnumber.pl
Product: Koha Reporter: Julian Maurice <julian.maurice>
Component: CatalogingAssignee: Julian Maurice <julian.maurice>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: trivial    
Priority: P5 - low CC: arthur.suzuki, david, lucas, m.de.rooy, wainuiwitikapark
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32903
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.04,22.05.11,21.11.19
Bug Depends on:    
Bug Blocks: 30975    
Attachments: Bug 32815: Fix cataloguing/value_builder/callnumber.pl
Bug 32815: Fix cataloguing/value_builder/callnumber.pl
Bug 32815: Fix cataloguing/value_builder/callnumber.pl
Bug 32815: Fix cataloguing/value_builder/callnumber.pl

Description Julian Maurice 2023-02-03 11:17:32 UTC
This is part of the refactoring happening in bug 30975
Comment 1 Julian Maurice 2023-02-03 11:18:06 UTC
Created attachment 146073 [details] [review]
Bug 32815: Fix cataloguing/value_builder/callnumber.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before
Comment 2 David Nind 2023-02-07 19:32:13 UTC Comment hidden (obsolete)
Comment 3 David Nind 2023-02-07 19:33:05 UTC
Created attachment 146356 [details] [review]
Bug 32815: Fix cataloguing/value_builder/callnumber.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2023-02-07 19:36:23 UTC
I mucked up the sign off, and have done again!

Testing notes (using KTD):

1. In a MARC21 instance, add the callnumber.pl plugin to 952$o for the BKS framework.
2. Edit an item for a record and add "PREFIX 0009678570" as the call number and save.
3. Edit another item for another record.
4. For the call number, enter "PREFIX" and then click on the three dots.
5. Note that it generates the call number as "PREFIX 9678572".

Note the description in the script says it should add leading zeros, but it doesn't. I have added bug 32903 for this.
Comment 5 Nick Clemens (kidclamp) 2023-03-03 19:03:34 UTC
Created attachment 147724 [details] [review]
Bug 32815: Fix cataloguing/value_builder/callnumber.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 6 Tomás Cohen Arazi 2023-03-06 12:49:02 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 7 Jacob O'Mara 2023-03-07 18:28:05 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.
Comment 8 Lucas Gass 2023-03-10 17:27:05 UTC
Backported to 22.05.x for upcoming 22.05.11
Comment 9 Arthur Suzuki 2023-03-29 14:36:17 UTC
applied to 21.11 for 21.11.19
Comment 10 wainuiwitikapark 2023-04-27 05:42:59 UTC
Not backported to 21.05.x