Summary: | Clean up cataloguing/value_builder/marc21_field_005.pl | ||
---|---|---|---|
Product: | Koha | Reporter: | Julian Maurice <julian.maurice> |
Component: | Cataloging | Assignee: | Julian Maurice <julian.maurice> |
Status: | RESOLVED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | david, m.de.rooy |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.06
|
|
Bug Depends on: | |||
Bug Blocks: | 30975 | ||
Attachments: |
Bug 32818: Fix cataloguing/value_builder/marc21_field_005.pl
Bug 32818: Fix cataloguing/value_builder/marc21_field_005.pl Bug 32818: Fix cataloguing/value_builder/marc21_field_005.pl |
Description
Julian Maurice
2023-02-03 11:26:37 UTC
Created attachment 146076 [details] [review] Bug 32818: Fix cataloguing/value_builder/marc21_field_005.pl Remove unnecessary return statement This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before This one is actually only a cleanup patch that is not needed for bug 30975. Removing the dependency link Created attachment 148847 [details] [review] Bug 32818: Fix cataloguing/value_builder/marc21_field_005.pl Remove unnecessary return statement This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before Signed-off-by: David Nind <david@davidnind.com> How I tested ~~~~~~~~~~~~ 1. Applied bug 30975 (interactive, commented out the first patch) - this takes a while as you have to say yes to all the dependent bugs. 2. Apply this patch - say no to apply dependent bugs (already done is step 1). 3. The plugin marc21_field_005.pl is already added to 005 for the MARC21 bibliographic frameworks in KTD. 4. Edit a bibliographic record: empty the 005 field, change to another field, then click back into 005 - it should be autopopulated with a value. 5. Create a new record and click in 005 - - it should be autopopulated with a value. Description ~~~~~~~~~~~ This is a standard cataloguing plugin. It autopopulates the 005 field with the required value when you click in the field. (From the Library of Congress: Sixteen characters that indicate the date and time of the latest record transaction and serve as a version identifier for the record.) Created attachment 150095 [details] [review] Bug 32818: Fix cataloguing/value_builder/marc21_field_005.pl Remove unnecessary return statement This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.05. Nice work everyone, thanks! Nice work, thanks everyone! Pushed to 22.11.x for the next release. |