Bug 32833

Summary: Fix cataloguing/value_builder/unimarc_field_121a.pl
Product: Koha Reporter: Julian Maurice <julian.maurice>
Component: CatalogingAssignee: Julian Maurice <julian.maurice>
Status: RESOLVED FIXED QA Contact: Marcel de Rooy <m.de.rooy>
Severity: trivial    
Priority: P5 - low CC: david, m.de.rooy, matt.blenkinsop
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.05
Bug Depends on:    
Bug Blocks: 30975    
Attachments: Bug 32833: Fix cataloguing/value_builder/unimarc_field_121a.pl
Bug 32833: Fix cataloguing/value_builder/unimarc_field_121a.pl
Bug 32833: Fix cataloguing/value_builder/unimarc_field_121a.pl
Bug 32833: Fix cataloguing/value_builder/unimarc_field_121a.pl

Description Julian Maurice 2023-02-03 12:57:01 UTC
This is part of the refactoring happening in bug 30975
Comment 1 Julian Maurice 2023-02-03 12:57:36 UTC
Created attachment 146098 [details] [review]
Bug 32833: Fix cataloguing/value_builder/unimarc_field_121a.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before
Comment 2 Julian Maurice 2023-02-17 10:11:53 UTC
Created attachment 146769 [details] [review]
Bug 32833: Fix cataloguing/value_builder/unimarc_field_121a.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before
Comment 3 David Nind 2023-03-23 19:14:20 UTC
Created attachment 148621 [details] [review]
Bug 32833: Fix cataloguing/value_builder/unimarc_field_121a.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2023-03-23 19:15:04 UTC
How I tested
~~~~~~~~~~~~

1. The plugin is already added to the subfield for the default UNIMARC bibliographic framework in KTD.
2. Edit a bibliographic record.
3. Select the tag editor for the subfield.
4. Options and values should be the same before and after the patch is applied.

Description
~~~~~~~~~~~

This is a standard UNIMARC value builder for a subfield - it displays a form to select the values that make up the subfield.
Comment 5 Marcel de Rooy 2023-03-24 08:34:25 UTC
Created attachment 148636 [details] [review]
Bug 32833: Fix cataloguing/value_builder/unimarc_field_121a.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 6 Tomás Cohen Arazi 2023-03-27 09:43:40 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 7 Matt Blenkinsop 2023-04-11 08:48:17 UTC
Nice work everyone!

Pushed to stable for 22.11.x