| Summary: | Clean up cataloguing/value_builder/unimarc_field_146a.pl | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Julian Maurice <julian.maurice> |
| Component: | Cataloging | Assignee: | Julian Maurice <julian.maurice> |
| Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | david, m.de.rooy, victor |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.06
|
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 30975 | ||
| Attachments: |
Bug 32865: Fix cataloguing/value_builder/unimarc_field_146a.pl
Bug 32865: Fix cataloguing/value_builder/unimarc_field_146a.pl Bug 32865: Fix cataloguing/value_builder/unimarc_field_146a.pl |
||
|
Description
Julian Maurice
2023-02-03 13:54:01 UTC
Created attachment 146130 [details] [review] Bug 32865: Fix cataloguing/value_builder/unimarc_field_146a.pl Remove unnecessary call to event.preventDefault() This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before This one is actually only a cleanup patch that is not needed for bug 30975, but bug 30975 is needed for the cleanup to be possible. I'm sure there is a reason that this has "Depends on: 30975" instead of "Blocks: 30975" like most of the other bugs for this change. While it is a bit tedious to say "y" to all the depends on bugs, it eventually fails when applying bug 30975. I originally didn't read comment #2 - please ignore comment #3! Created attachment 148843 [details] [review] Bug 32865: Fix cataloguing/value_builder/unimarc_field_146a.pl Remove unnecessary call to event.preventDefault() This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before Signed-off-by: David Nind <david@davidnind.com> How I tested ~~~~~~~~~~~~ 1. Applied bug 30975 (interactive, commented out the first patch) - this takes a while as you have to say yes to all the dependent bugs. 2. Remove the authorized value list currently used for 146$a in KTD. 3. Add the plugin unimarc_field_146a.pl to subfield 146$a for the default UNIMARC bibliographic framework in KTD. 4. Edit a bibliographic record. 5. Select the tag editor for the subfield. 6. Options and values should be the same before and after the patch is applied. Description ~~~~~~~~~~~ This is a standard UNIMARC value builder for a subfield - it displays a form to select the values that make up the subfield. Created attachment 150099 [details] [review] Bug 32865: Fix cataloguing/value_builder/unimarc_field_146a.pl Remove unnecessary call to event.preventDefault() This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Thanks Katrin, you beat me to it :) I confirm the that the plugin continues to work as before. Pushed to master for 23.05. Nice work everyone, thanks! Nice work, thanks everyone! Pushed to 22.11.x for the next release. |