Bug 32874

Summary: Fix cataloguing/value_builder/unimarc_field_700-4.pl
Product: Koha Reporter: Julian Maurice <julian.maurice>
Component: CatalogingAssignee: Julian Maurice <julian.maurice>
Status: RESOLVED FIXED QA Contact: Testopia <testopia>
Severity: trivial    
Priority: P5 - low CC: david, m.de.rooy
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3007
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.06
Bug Depends on:    
Bug Blocks: 30975    
Attachments: Bug 32874: Fix cataloguing/value_builder/unimarc_field_700-4.pl
Bug 32874: Fix cataloguing/value_builder/unimarc_field_700-4.pl
Bug 32874: Fix cataloguing/value_builder/unimarc_field_700-4.pl
Bug 32874: Fix cataloguing/value_builder/unimarc_field_700-4.pl

Description Julian Maurice 2023-02-03 14:07:09 UTC
This is part of the refactoring happening in bug 30975
Comment 1 Julian Maurice 2023-02-03 14:07:35 UTC
Created attachment 146140 [details] [review]
Bug 32874: Fix cataloguing/value_builder/unimarc_field_700-4.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before
Comment 2 Julian Maurice 2023-02-17 10:18:37 UTC
Created attachment 146808 [details] [review]
Bug 32874: Fix cataloguing/value_builder/unimarc_field_700-4.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before
Comment 3 David Nind 2023-03-30 19:10:53 UTC
Created attachment 149004 [details] [review]
Bug 32874: Fix cataloguing/value_builder/unimarc_field_700-4.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2023-03-30 19:16:51 UTC
How I tested
~~~~~~~~~~~~

1. Remove the qualif authorized value list from 700$4 and add the unimarc_field_700-4.pl cataloging plugin to the UNIMARC bibliographic framework in KTD.
2. Edit a bibliographic record.
3. Select the tag editor for the subfield.
4. Options and values should be the same before and after the patch is applied.

Description
~~~~~~~~~~~

This is a standard UNIMARC value builder for a subfield - it displays a form to select the values that make up the subfield.

Note: With the cataloguing plugin there are a limited number of options available (5) compared with using the qualif authorized values list (Function codes (author, editor, collaborator, etc.) used in UNIMARC 7XX $4 (French)). Also, the text on the form is written in French. Maybe this needs to be reviewed by someone familiar with UNIMARC to determine whether this plugin is still current.
Comment 5 Katrin Fischer 2023-04-22 21:05:53 UTC
Created attachment 150093 [details] [review]
Bug 32874: Fix cataloguing/value_builder/unimarc_field_700-4.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Tomás Cohen Arazi 2023-05-05 12:17:10 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 7 Martin Renvoize 2023-05-11 12:25:39 UTC
Many hands makes light work, thankyou everyone!

Pushed to 22.11.x for the next release
Comment 8 David Nind 2023-10-08 20:39:25 UTC
Just an FYI - Bug 3007 will now remove this value builder.