Summary: | Curbside pickups - Order "To be staged" by date and time of scheduled pickup | ||
---|---|---|---|
Product: | Koha | Reporter: | Caroline Cyr La Rose <caroline.cyr-la-rose> |
Component: | Circulation | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | gmcharlt, jonathan.druart, kyle.m.hall, lucas, matt.blenkinsop, nick, tomascohen |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32890 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.05
|
|
Circulation function: | |||
Bug Depends on: | 30650 | ||
Bug Blocks: | |||
Attachments: |
Bug 32883: Correct cubside pickups ordering
Bug 32883: Correct cubside pickups ordering Bug 32883: Correct cubside pickups ordering Bug 32883: Correct cubside pickups ordering Bug 32883: (QA follow-up) Adjust ordering for pickups |
Description
Caroline Cyr La Rose
2023-02-03 19:13:51 UTC
Created attachment 146283 [details] [review] Bug 32883: Correct cubside pickups ordering They are displayed by date of creation, it's not what we want for "to be staged" for instance, where it needs to be ordered by date/time of scheduled pickup. Test plan: Create several curbside pickups, to have some in the different tabs Confirm that the order is the one you expect. => to be staged ordered by pickup date/time => stage and ready ordered by staged (mark as staged) date/time => patron is outside ordered by arrival date/time => delivered today ordered by *desc* delivered date/time We could add DataTables to those tables, but this one line patch is fixing the default sort. It should be done on a separate bug in my opinion. The patch works as advertised. I'm not sure about the "Staged and ready" order... Shouldn't it still be by scheduled pickup time? I've never used this IRL, so I'm not sure of the workflow, but I feel like I could prepare the pickups in any order (as I come to them on my holds shelf for example, or I picked them up on my holds shelf, put them on a cart and went to my desk to scan them), but I'd still want to see the most "pressing" at the top, so I can check if the patron is there... Created attachment 146305 [details] [review] Bug 32883: Correct cubside pickups ordering They are displayed by date of creation, it's not what we want for "to be staged" for instance, where it needs to be ordered by date/time of scheduled pickup. Test plan: Create several curbside pickups, to have some in the different tabs Confirm that the order is the one you expect. => to be staged ordered by pickup date/time => stage and ready ordered by pickup date/time => patron is outside ordered by arrival date/time => delivered today ordered by *desc* delivered date/time (In reply to Caroline Cyr La Rose from comment #3) > I'm not sure about the "Staged and ready" order... Shouldn't it still be by > scheduled pickup time? Yes, I think you are right. I modified the patch. Created attachment 146334 [details] [review] Bug 32883: Correct cubside pickups ordering They are displayed by date of creation, it's not what we want for "to be staged" for instance, where it needs to be ordered by date/time of scheduled pickup. Test plan: Create several curbside pickups, to have some in the different tabs Confirm that the order is the one you expect. => to be staged ordered by pickup date/time => stage and ready ordered by pickup date/time => patron is outside ordered by arrival date/time => delivered today ordered by *desc* delivered date/time Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Cool, thanks Jonathan! The "Patron is outside" tab is now order by "arrival" but we still only display "Pickup date/time" I think we want to order by the pickup date/time - so even if the patron arrives early, they still get their pickup in their slot We should show the arrival time, but that's not for this bug Then I think the line should be: { order_by => [ { -desc => 'delivered_datetime' }, 'scheduled_pickup_datetime' ], } I won't have time to work more on this soon unfortunately. Created attachment 148163 [details] [review] Bug 32883: Correct cubside pickups ordering They are displayed by date of creation, it's not what we want for "to be staged" for instance, where it needs to be ordered by date/time of scheduled pickup. Test plan: Create several curbside pickups, to have some in the different tabs Confirm that the order is the one you expect. => to be staged ordered by pickup date/time => stage and ready ordered by pickup date/time => patron is outside ordered by arrival date/time => delivered today ordered by *desc* delivered date/time Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 148164 [details] [review] Bug 32883: (QA follow-up) Adjust ordering for pickups Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to master for 23.05. Nice work everyone, thanks! Nice work everyone! Pushed to stable for 22.11.x Missing dependencies for 22.05.x, no backport. |