Summary: | Curbside pickups - Cannot select slot in the last hour | ||
---|---|---|---|
Product: | Koha | Reporter: | Caroline Cyr La Rose <caroline.cyr-la-rose> |
Component: | Circulation | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | david, gmcharlt, jacob.omara, jonathan.druart, kyle.m.hall, lucas |
Version: | Main | Keywords: | rel_22_11_candidate |
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.04
|
|
Bug Depends on: | 30650 | ||
Bug Blocks: | |||
Attachments: |
Bug 32891: Fix slot selection in last hour
Bug 32891: Fix slot selection in last hour Bug 32891: Fix slot selection in last hour Bug 32891: Fix slot selection in last hour Bug 32891: (QA follow-up) Fix perlcritic error |
Description
Caroline Cyr La Rose
2023-02-06 18:13:09 UTC
I tested Caroline's setup and I get the same message as well: 1. I don't think it is the order of the time slots, as it happened to me for a day when they were in order (Monday) (see bug 32788). 2. I changed Henry's home library to Centerville, but the message still occurred. 3. I couldn't see any errors in the browser console or error logs. 4. I also tried days a week or two in the future, but it still occurred. 5. There are tests (in t/db_dependent/Koha/CurbsidePickups.t) that generate the "Wrong slot selected" message - they seem logical, but shouldn't be something that you can replicate in the staff interface as you can only select from the date and times configured and displayed: #Day is not ok Cannot create a pickup on a day without opening slots defined #Day ok but datetime not ok Cannot create a pickup on a time without opening slots defined #Day ok, datetime inside the opening slot, but wrong (15:15 for instance) Cannot create a pickup on a time that is not matching the start of an interval IRC log discussion links: * 2023-02-03: https://irc.koha-community.org/koha/2023-02-03#i_2470945 * 2023-02-06: https://irc.koha-community.org/koha/2023-02-06#i_2471054 Created attachment 146306 [details] [review] Bug 32891: Fix slot selection in last hour If the curbside pickup module is configured with slot not on the hour (minutes=00), the slots in the last (not complete) hour won't be selectable. Test plan: Create the following configuration: pickup interval: 10 Opening hours: 08:00 to 11:30 Create a pickup and select 11:10 or 11:20 => Without this patch the pickup is not created and the UI displays "Wrong slot selected" => With this patch you are able to create the pickup Created attachment 146314 [details] [review] Bug 32891: Fix slot selection in last hour If the curbside pickup module is configured with slot not on the hour (minutes=00), the slots in the last (not complete) hour won't be selectable. Test plan: Create the following configuration: pickup interval: 10 Opening hours: 08:00 to 11:30 Create a pickup and select 11:10 or 11:20 => Without this patch the pickup is not created and the UI displays "Wrong slot selected" => With this patch you are able to create the pickup Signed-off-by: David Nind <david@davidnind.com> Thanks Jonathan for figuring out the cause of the issue! Created attachment 146332 [details] [review] Bug 32891: Fix slot selection in last hour If the curbside pickup module is configured with slot not on the hour (minutes=00), the slots in the last (not complete) hour won't be selectable. Test plan: Create the following configuration: pickup interval: 10 Opening hours: 08:00 to 11:30 Create a pickup and select 11:10 or 11:20 => Without this patch the pickup is not created and the UI displays "Wrong slot selected" => With this patch you are able to create the pickup Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Thanks Jonathan! Created attachment 147026 [details] [review] Bug 32891: Fix slot selection in last hour If the curbside pickup module is configured with slot not on the hour (minutes=00), the slots in the last (not complete) hour won't be selectable. Test plan: Create the following configuration: pickup interval: 10 Opening hours: 08:00 to 11:30 Create a pickup and select 11:10 or 11:20 => Without this patch the pickup is not created and the UI displays "Wrong slot selected" => With this patch you are able to create the pickup Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 147027 [details] [review] Bug 32891: (QA follow-up) Fix perlcritic error Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Pushed to master for 22.11. Nice work everyone, thanks! Nice work, thanks everyone! Pushed to 22.11.x for the next release. Nice work, thanks everyone! Pushed to 22.11.x for the next release. Missing dependencies for 22.05.x, no backport. |