Bug 32912

Summary: Use template wrapper for notices tabs
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Katrin Fischer <katrin.fischer>
Severity: minor    
Priority: P5 - low CC: lucas, martin.renvoize, testopia
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Small patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.04
Circulation function:
Bug Depends on: 32571    
Bug Blocks: 33622    
Attachments: Bug 32912: Use template wrapper for notices tabs
Bug 32912: Use template wrapper for notices tabs
Bug 32912: Use template wrapper for notices tabs

Description Owen Leonard 2023-02-08 17:09:41 UTC
Continuing the work of Bug 32571, the notices template should be updated to use the new WRAPPER for tabs.
Comment 1 Owen Leonard 2023-02-08 17:10:15 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2023-02-08 17:37:50 UTC Comment hidden (obsolete)
Comment 3 David Nind 2023-02-08 18:35:09 UTC
Created attachment 146407 [details] [review]
Bug 32912: Use template wrapper for notices tabs

This patch updates the notices template to replace tab markup with
the use of WRAPPERs.

This patch also makes a minor correction to the color of Bootstrap
panels.

To test you must have more than one translation installed, and the
TranslateNotices preference should be enabled.

- Apply the patch and go to Tools -> Notices.
- Edit a notice.
- You should see tabs for each available language, for example
  Default, English, French.
- Test adding content to each language to confirm that the correct
  information is saved under the correct tab.
- Disable the TranslateNotices preference to confirm that the
  display is still correct without the tabbed interface.

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 Katrin Fischer 2023-02-24 16:55:12 UTC
Created attachment 147367 [details] [review]
Bug 32912: Use template wrapper for notices tabs

This patch updates the notices template to replace tab markup with
the use of WRAPPERs.

This patch also makes a minor correction to the color of Bootstrap
panels.

To test you must have more than one translation installed, and the
TranslateNotices preference should be enabled.

- Apply the patch and go to Tools -> Notices.
- Edit a notice.
- You should see tabs for each available language, for example
  Default, English, French.
- Test adding content to each language to confirm that the correct
  information is saved under the correct tab.
- Disable the TranslateNotices preference to confirm that the
  display is still correct without the tabbed interface.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 5 Tomás Cohen Arazi (tcohen) 2023-02-24 19:57:00 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 6 Matt Blenkinsop 2023-02-28 16:40:41 UTC
Nice work everyone!

Pushed to stable for 22.11.x
Comment 7 Lucas Gass (lukeg) 2023-03-08 13:27:26 UTC
Missing dependencies for 22.05.x, no backport.