Summary: | Remove space in shebang | ||
---|---|---|---|
Product: | Koha | Reporter: | Magnus Enger <magnus> |
Component: | Architecture, internals, and plumbing | Assignee: | Magnus Enger <magnus> |
Status: | CLOSED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | lucas, martin.renvoize |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
23.05.00,22.11.04
|
Circulation function: | |
Attachments: |
Bug 32922: Remove space in shebang
Bug 32922: Remove space in shebang Bug 32922: Remove space in shebang Bug 32922: Remove space in shebang Bug 32922: (follow-up) Fix two additional occurences Bug 29449: Show userid on "Personal details" tab |
Description
Magnus Enger
2023-02-09 07:51:12 UTC
Created attachment 146416 [details] [review] Bug 32922: Remove space in shebang Some of our scripts have a space in the "shebang" (first) line: This is not illegal, and it does work, but it is good to be consistent, so this patch removes the space. To test: - Run: grep -rn --include=*.pl '#! /usr/' * - See the list of files that have a space in the shebang - Apply the patch - Run the command again, there should be no output, meaning there are no more files with space in the shebang - Have a look at the patch and check that it only changes the shebangs - Sign off Created attachment 146417 [details] [review] Bug 32922: Remove space in shebang Some of our scripts have a space in the "shebang" (first) line: #! /usr/bin/perl This is not illegal, and it does work, but it is good to be consistent, so this patch removes the space. To test: - Run: grep -rn --include=*.pl '#! /usr/' * - See the list of files that have a space in the shebang - Apply the patch - Run the command again, there should be no output, meaning there are no more files with space in the shebang - Have a look at the patch and check that it only changes the shebangs - Sign off Created attachment 146419 [details] [review] Bug 32922: Remove space in shebang Some of our scripts have a space in the "shebang" (first) line: #! /usr/bin/perl This is not illegal, and it does work, but it is good to be consistent, so this patch removes the space. To test: - Run: grep -rn --include=*.pl '#! /usr/' * - See the list of files that have a space in the shebang - Apply the patch - Run the command again, there should be no output, meaning there are no more files with space in the shebang - Have a look at the patch and check that it only changes the shebangs - Sign off Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Created attachment 146498 [details] [review] Bug 32922: Remove space in shebang Some of our scripts have a space in the "shebang" (first) line: #! /usr/bin/perl This is not illegal, and it does work, but it is good to be consistent, so this patch removes the space. To test: - Run: grep -rn --include=*.pl '#! /usr/' * - See the list of files that have a space in the shebang - Apply the patch - Run the command again, there should be no output, meaning there are no more files with space in the shebang - Have a look at the patch and check that it only changes the shebangs - Sign off Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 146499 [details] [review] Bug 32922: (follow-up) Fix two additional occurences Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Oops.. just spotted this was SO'd by Matt.. but I've gone through a QA process on it already. All working nicely and is a good general consistency improvement. Passing QA.. Tomas, feel free to push back for an independent QA if you want it . Pushed to master for 23.05. Nice work everyone, thanks! Created attachment 147193 [details] [review] Bug 29449: Show userid on "Personal details" tab To reproduce: - Login to the OPAC - Go to the "Personal details" tab - Verify the Username/userid of the logged in user is not shown anywhere To test: - Apply this patch - Reload the "Personal details" tab - Verify that "Username:" and the userid is now shown below the "Library card number" - Try adding "userid" to PatronSelfModificationBorrowerUnwantedField and verify the field is hidden as expected - Log out - Go to "Don't have an account? Register here." - Verify "Username:" is *not* shown - Sign off Comment on attachment 147193 [details] [review] Bug 29449: Show userid on "Personal details" tab Wrong bug, sorry! Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release Does not apply to 22.05.x, no backport. |