Bug 32924

Summary: Filter agreements by logged in librarian
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: ERMAssignee: Jonathan Druart <jonathan.druart>
Status: RESOLVED FIXED QA Contact:
Severity: enhancement    
Priority: P5 - low CC: aude.charillon, jonathan.druart, jonathan.field, martin.renvoize, matt.blenkinsop, pedro.amorim, victor
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Aude Charillon Documentation submission: https://gitlab.com/koha-community/koha-manual/-/merge_requests/868
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.06
Bug Depends on: 32030    
Bug Blocks:    
Attachments: Bug 32924: Add the ability to filter agreement by logged in user
Bug 32924: (follow-up) Add left margin to 'Show mine only' label
Bug 32924: Add the ability to filter agreement by logged in user
Bug 32924: (follow-up) Add left margin to 'Show mine only' label
Bug 32924: Add the ability to filter agreement by logged in user
Bug 32924: (follow-up) Add left margin to 'Show mine only' label

Description Jonathan Druart 2023-02-09 13:02:12 UTC

    
Comment 1 Jonathan Druart 2023-02-09 13:04:09 UTC
Created attachment 146427 [details] [review]
Bug 32924: Add the ability to filter agreement by logged in user

This patch adds a new filter checkbox at the top of the agreement list
"Show only mine" that will display agreements linked with the logged in
user.

Test plan:
Create several agreements, add your current logged in user to some of
them
On the agreement list view us the new checkbox to filter the agreements
and see those where you are involved in.
Comment 2 Jonathan Druart 2023-02-09 13:07:44 UTC
It's packed on the same line as the existing filter. But having 3 lines (1 for date, 1 for "show mine" and 1 for the button) takes a lot of space at the top. Something better to suggest?

https://snipboard.io/UghF4d.jpg
Comment 3 Pedro Amorim 2023-02-09 15:15:24 UTC
Created attachment 146433 [details] [review]
Bug 32924: (follow-up) Add left margin to 'Show mine only' label
Comment 4 Pedro Amorim 2023-02-09 15:18:35 UTC
Created attachment 146434 [details] [review]
Bug 32924: Add the ability to filter agreement by logged in user

This patch adds a new filter checkbox at the top of the agreement list
"Show only mine" that will display agreements linked with the logged in
user.

Test plan:
Create several agreements, add your current logged in user to some of
them
On the agreement list view us the new checkbox to filter the agreements
and see those where you are involved in.

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Comment 5 Pedro Amorim 2023-02-09 15:18:37 UTC
Created attachment 146435 [details] [review]
Bug 32924: (follow-up) Add left margin to 'Show mine only' label

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Comment 6 Victor Grousset/tuxayo 2023-03-06 22:57:15 UTC
Created attachment 147812 [details] [review]
Bug 32924: Add the ability to filter agreement by logged in user

This patch adds a new filter checkbox at the top of the agreement list
"Show only mine" that will display agreements linked with the logged in
user.

Test plan:
Create several agreements, add your current logged in user to some of
them
On the agreement list view us the new checkbox to filter the agreements
and see those where you are involved in.

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Comment 7 Victor Grousset/tuxayo 2023-03-06 22:57:17 UTC
Created attachment 147813 [details] [review]
Bug 32924: (follow-up) Add left margin to 'Show mine only' label

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Comment 8 Victor Grousset/tuxayo 2023-03-06 22:58:05 UTC
Works, QA script happy, code looks good, passing QA :)
Comment 9 Tomás Cohen Arazi 2023-03-07 18:33:20 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 10 Matt Blenkinsop 2023-03-09 09:44:04 UTC
Enhancement - not backporting to 22.11.x. 
Setting to Needs documenting. 
Nice work everyone!
Comment 11 Martin Renvoize 2023-05-11 16:17:08 UTC
For 22.11.06 I've decided to incorporate the majority of ERM improvements.. a lot of work has gone into improving ERM this cycle and for long term maintenance I think it makes sense to include these changes at this stage.
Comment 12 Martin Renvoize 2023-05-11 16:19:15 UTC
Many hands makes light work, thankyou everyone!

Pushed to 22.11.x for the next release
Comment 13 Aude Charillon 2024-04-26 09:31:22 UTC
Added to the Manual.