Bug 32935

Summary: basketgroup.js is not longer used and should be removed
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: Architecture, internals, and plumbingAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: jonathan.druart, lucas
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31056
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.04
Circulation function:
Bug Depends on: 13614    
Bug Blocks:    
Attachments: Bug 32935: (bug 13614 follow-up) Remove unused basketgroup.js
Bug 32935: (bug 13614 follow-up) Remove unused basketgroup.js
Bug 32935: (bug 13614 follow-up) Remove unused basketgroup.js

Description Katrin Fischer 2023-02-09 23:07:18 UTC
Looking into bug 31056 it seems like this file is no longer used anywhere. 
If confirmed, we could remove it.

See also:
Bug 13614: Replace usage of YUI on basket groups page
Comment 1 Jonathan Druart 2023-02-23 08:57:49 UTC
Created attachment 147194 [details] [review]
Bug 32935: (bug 13614 follow-up) Remove unused basketgroup.js

Bug 13614 removed it. On bug 31056 we noticed that one function was
still needed but we copied it in the corresponding .tt

Now this JS file is no longer used and should be removed from the
codebase

Test plan:
  git grep basketgroup.js
must not return anything
Comment 2 Katrin Fischer 2023-02-23 22:37:46 UTC
Created attachment 147278 [details] [review]
Bug 32935: (bug 13614 follow-up) Remove unused basketgroup.js

Bug 13614 removed it. On bug 31056 we noticed that one function was
still needed but we copied it in the corresponding .tt

Now this JS file is no longer used and should be removed from the
codebase

Test plan:
  git grep basketgroup.js
must not return anything

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 3 Nick Clemens (kidclamp) 2023-02-24 20:18:06 UTC
Created attachment 147398 [details] [review]
Bug 32935: (bug 13614 follow-up) Remove unused basketgroup.js

Bug 13614 removed it. On bug 31056 we noticed that one function was
still needed but we copied it in the corresponding .tt

Now this JS file is no longer used and should be removed from the
codebase

Test plan:
  git grep basketgroup.js
must not return anything

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 4 Tomás Cohen Arazi (tcohen) 2023-02-24 20:58:13 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 5 Matt Blenkinsop 2023-02-28 17:58:20 UTC
Nice work everyone!

Pushed to stable for 22.11.x
Comment 6 Lucas Gass (lukeg) 2023-03-08 14:06:30 UTC
Missing dependencies for 22.05.x, no backport.