Bug 32946

Summary:	'Send list/cart' forms in OPAC is misaligned
Product:	Koha	Reporter:	Katrin Fischer <katrin.fischer>
Component:	OPAC	Assignee:	Owen Leonard <oleonard>
Status:	RESOLVED FIXED	QA Contact:	Katrin Fischer <katrin.fischer>
Severity:	minor
Priority:	P5 - low	CC:	david
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Small patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	23.05.00,22.11.04
Circulation function:
Attachments:	Bug 32946: 'Send list' form in OPAC is misaligned Bug 32946: 'Send list' form in OPAC is misaligned Bug 32946: 'Send list' form in OPAC is misaligned Bug 32946: (QA follow-up) Fix "Send cart" form

Description Katrin Fischer 2023-02-10 21:10:29 UTC

Not sure what happened there, but the labels and input fields are no longer aligned correctly and when you change the window size it becomes even more apparent.

To test:
* Create a private list in the OPAC
* Open the list and click "send list" to send by email
* The "comment" label for example moves directly after the email address field.

Comment 1 Owen Leonard 2023-02-13 16:06:54 UTC

Created attachment 146588 [details] [review]
Bug 32946: 'Send list' form in OPAC is misaligned

This patch tweaks the OPAC CSS and the send list template so that form
fields are laid out correctly.

To test, apply the patch and rebuild the OPAC CSS.

- Log in to the OPAC and create a list if necessary.
- In the OPAC's view of the list contents, click the "Send list" button.
- In the pop-up window the form layout should look correct.

Comment 2 Matt Blenkinsop 2023-02-15 16:04:54 UTC

Created attachment 146696 [details] [review]
Bug 32946: 'Send list' form in OPAC is misaligned

This patch tweaks the OPAC CSS and the send list template so that form
fields are laid out correctly.

To test, apply the patch and rebuild the OPAC CSS.

- Log in to the OPAC and create a list if necessary.
- In the OPAC's view of the list contents, click the "Send list" button.
- In the pop-up window the form layout should look correct.

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>

Comment 3 Katrin Fischer 2023-02-15 22:11:50 UTC

Created attachment 146702 [details] [review]
Bug 32946: 'Send list' form in OPAC is misaligned

This patch tweaks the OPAC CSS and the send list template so that form
fields are laid out correctly.

To test, apply the patch and rebuild the OPAC CSS.

- Log in to the OPAC and create a list if necessary.
- In the OPAC's view of the list contents, click the "Send list" button.
- In the pop-up window the form layout should look correct.

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Comment 4 Katrin Fischer 2023-02-15 22:11:53 UTC

Created attachment 146703 [details] [review]
Bug 32946: (QA follow-up) Fix "Send cart" form

The send cart form is almost identical to the list
'Send list' form and requires the exact same fixes
to look good. This patch achieves the same look for
both forms.

To test:
* Fill your cart in the OPAC
* Open the cart to view contents
* Click on "Send"
* The form shoud look nicely aligned
* Compary to form for sending lists, they should look the same

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Comment 5 Tomás Cohen Arazi (tcohen) 2023-02-16 15:02:17 UTC

Pushed to master for 23.05.

Nice work everyone, thanks!

Comment 6 Martin Renvoize (ashimema) 2023-02-24 07:53:03 UTC

Many hands makes light work, thankyou everyone!

Pushed to 22.11.x for the next release

Comment 7 Katrin Fischer 2023-06-10 22:16:51 UTC

*** Bug 32384 has been marked as a duplicate of this bug. ***