Description
Caroline Cyr La Rose
2023-02-14 21:38:50 UTC
Terminology also says we should use 'library' instead of 'branch'. https://wiki.koha-community.org/wiki/Terminology#B Created attachment 146655 [details] [review] Bug 32964: OPACResultsMaxItemsUnavailable description is misleading This patch rephrases the last part of the description of the OPACResultsMaxItemsUnavailable system preference to clarify the link to the OPACResultsUnavailableGroupingBy option. It also changes some terminology to follow the guidelines (capitalization, library instead of branch). To test: 1. Apply patch 2. Go to Administration > Global system preferences 3. Search for OPACResultsMaxItems 4. Read the sentence for OPACResultsMaxItemsUnavailable, make sure it makes sense, the grammar and spelling are ok, respects terminology and capitalization guidelines 5. Try the link in the description, make sure it goes to the correct syspref 6. Read the sentence and options for OPACResultsUnavailableGroupingBy, make sure it makes sense, the grammar and spelling are ok, respects terminology and capitalization guidelines 7. Optionally, try the various options, they should still work as intended (In reply to Caroline Cyr La Rose from comment #2) > Created attachment 146655 [details] [review] [review] > Bug 32964: OPACResultsMaxItemsUnavailable description is misleading > > This patch rephrases the last part of the description of the > OPACResultsMaxItemsUnavailable system preference to clarify the link > to the OPACResultsUnavailableGroupingBy option. > > It also changes some terminology to follow the guidelines > (capitalization, library instead of branch). > > To test: > 1. Apply patch > 2. Go to Administration > Global system preferences > 3. Search for OPACResultsMaxItems > 4. Read the sentence for OPACResultsMaxItemsUnavailable, make sure it > makes sense, the grammar and spelling are ok, respects terminology > and capitalization guidelines > 5. Try the link in the description, make sure it goes to the correct > syspref > 6. Read the sentence and options for OPACResultsUnavailableGroupingBy, > make sure it makes sense, the grammar and spelling are ok, respects > terminology and capitalization guidelines > 7. Optionally, try the various options, they should still work as > intended The terminology and grammar makes sense to me. Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Created attachment 147983 [details] [review] Bug 32964: OPACResultsMaxItemsUnavailable description is misleading This patch rephrases the last part of the description of the OPACResultsMaxItemsUnavailable system preference to clarify the link to the OPACResultsUnavailableGroupingBy option. It also changes some terminology to follow the guidelines (capitalization, library instead of branch). To test: 1. Apply patch 2. Go to Administration > Global system preferences 3. Search for OPACResultsMaxItems 4. Read the sentence for OPACResultsMaxItemsUnavailable, make sure it makes sense, the grammar and spelling are ok, respects terminology and capitalization guidelines 5. Try the link in the description, make sure it goes to the correct syspref 6. Read the sentence and options for OPACResultsUnavailableGroupingBy, make sure it makes sense, the grammar and spelling are ok, respects terminology and capitalization guidelines 7. Optionally, try the various options, they should still work as intended Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Created attachment 148637 [details] [review] Bug 32964: OPACResultsMaxItemsUnavailable description is misleading This patch rephrases the last part of the description of the OPACResultsMaxItemsUnavailable system preference to clarify the link to the OPACResultsUnavailableGroupingBy option. It also changes some terminology to follow the guidelines (capitalization, library instead of branch). To test: 1. Apply patch 2. Go to Administration > Global system preferences 3. Search for OPACResultsMaxItems 4. Read the sentence for OPACResultsMaxItemsUnavailable, make sure it makes sense, the grammar and spelling are ok, respects terminology and capitalization guidelines 5. Try the link in the description, make sure it goes to the correct syspref 6. Read the sentence and options for OPACResultsUnavailableGroupingBy, make sure it makes sense, the grammar and spelling are ok, respects terminology and capitalization guidelines 7. Optionally, try the various options, they should still work as intended Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 23.05. Nice work everyone, thanks! Intrigued by this report. I have the impression that you found a bug in the group by library option. As it once worked differently :) We are now renaming according to current behavior. Digging a bit furthere here. (In reply to Marcel de Rooy from comment #7) > Intrigued by this report. I have the impression that you found a bug in the > group by library option. As it once worked differently :) > We are now renaming according to current behavior. Digging a bit furthere > here. No, I must be wrong. The comments in the XSLT code are clear enough. But the description on the pref is confusing indeed. Caroline: What do you think of the additional rewording in the follow-up? Created attachment 148821 [details] [review] Bug 32964: (follow-up) Additional rewording for XSLT item display Test plan: Check OPAC preferences, OPACResultsMaxItems and siblings. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> <caroline> marcelr, the diff looks good to me, I'll sign off Created attachment 148919 [details] [review] Bug 32964: (follow-up) Additional rewording for XSLT item display Test plan: Check OPAC preferences, OPACResultsMaxItems and siblings. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> I signed off the followup, but I can't change the status back to Signed off. I'm not sure what the correct procedure is here. Thanks again Marcel! Caroline (In reply to Caroline Cyr La Rose from comment #12) > I signed off the followup, but I can't change the status back to Signed off. > I'm not sure what the correct procedure is here. > > Thanks again Marcel! > > Caroline This is fine. Thanks. I added the additional work keyword to alert the RM. Follow-up pushed to master. Thanks everyone. Nice work everyone! Pushed to stable for 22.11.x |