| Summary: | The EDIFACT message that receives an item should be linked on the 'Acquisition details' tab on catalogue details page | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | Acquisitions | Assignee: | Kyle M Hall (khall) <kyle> |
| Status: | Needs documenting --- | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | fridolin.somers, jeremy.evans |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
**Sponsored by** *PTFS Europe Ltd*
|
Version(s) released in: |
23.11.00
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 34853 | ||
| Attachments: |
Bug 32984: Add link to EDI invoice to "Invoice" column if there is one
Bug 32984: Add link to EDI invoice to "Invoice" column if there is one Bug 32984: (QA follow-up) Update to respect EDIFACT preference |
||
|
Description
Nick Clemens (kidclamp)
2023-02-16 15:12:01 UTC
Created attachment 146739 [details] [review] Bug 32984: Add link to EDI invoice to "Invoice" column if there is one Test Plan: 1) Find or create an item invoiced via an EDI INVOICE message 2) Ensure you have the edi_manage subpermission 3) View catalogue/detail.pl, not the invoice link in the invoice column 4) Apply this patch 5) Restart all the things! 6) Reload catalogue/detail.pl 7) Note the new "(EDI invoice)" link in the column for the item 8) Verify the link does not show if you do not have the edi_manage subpermission Created attachment 155456 [details] [review] Bug 32984: Add link to EDI invoice to "Invoice" column if there is one Test Plan: 1) Find or create an item invoiced via an EDI INVOICE message 2) Ensure you have the edi_manage subpermission 3) View catalogue/detail.pl, not the invoice link in the invoice column 4) Apply this patch 5) Restart all the things! 6) Reload catalogue/detail.pl 7) Note the new "(EDI invoice)" link in the column for the item 8) Verify the link does not show if you do not have the edi_manage subpermission Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Trivial patch, tested and signed off by a customer of ptfs-europe. I'm opting to QA as it's useful addition without risk of regressions. QA scripts are happy and code is simple and working Passing QA Created attachment 155457 [details] [review] Bug 32984: (QA follow-up) Update to respect EDIFACT preference Since the first submission of this patch we have introduced a system preference to enable/disable edifact in it's entirety. This patch adds the check for this preference. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> This is working well but it would be easier to read on the display if the EDI invoice link can start on a new line underneath the Invoice number. At the moment it makes the Invoice number harder to read. Pushed to master for 23.11. Nice work everyone, thanks! Follow-up to take care of comment above added to new bug linked. Bug 34853 Enhancement not pushed to 23.05.x |