Bug 32993

Summary: Holds priority changed incorrectly with dropdown selector
Product: Koha Reporter: Emmi Takkinen <emmi.takkinen>
Component: Hold requestsAssignee: Bugs List <koha-bugs>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: danyonsewell, gmcharlt, kkrueger, kyle, lucas, m.de.rooy
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.06,22.05.14,21.11.22
Circulation function:
Attachments: Bug 32993: Holds priority changed incorrectly with dropdown selector
Bug 32993: Holds priority changed incorrectly with dropdown selector
Bug 32993: Holds priority changed incorrectly with dropdown selector
Bug 32993: Holds priority changed incorrectly with dropdown selector
Bug 32993: Holds priority changed incorrectly with dropdown selector

Description Emmi Takkinen 2023-02-17 12:00:23 UTC
When one tries to change holds priority via dropdown selector, holds priority doesn't change correctly.

To test:
1. Find record with at least 3 holds.
2. Change first holds priority as 2.
=> Priority is changed to 3.
3. Try to change priority back to 1.
=> Priority is changed to 2.  

Somewhat same as bug 19636 but not quite.
Comment 1 Kyle M Hall (khall) 2023-04-28 18:31:47 UTC
Created attachment 150411 [details] [review]
Bug 32993: Holds priority changed incorrectly with dropdown selector

Test Plan:
1) Find record with at least 3 holds.
2) Change first holds priority as 2, Priority is changed to 3.
3) Try to change priority back to 1, Priority is changed to 2.
4) Apply this patch
5) Reload the page
2) Change first holds priority as 2, Priority is changed to 2.
3) Try to change priority back to 1, Priority is changed to 1.
Comment 2 David Nind 2023-04-28 18:57:45 UTC
Created attachment 150417 [details] [review]
Bug 32993: Holds priority changed incorrectly with dropdown selector

Test Plan:
1) Find record with at least 3 holds.
2) Change first holds priority as 2, Priority is changed to 3.
3) Try to change priority back to 1, Priority is changed to 2.
4) Apply this patch
5) Reload the page
2) Change first holds priority as 2, Priority is changed to 2.
3) Try to change priority back to 1, Priority is changed to 1.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Emmi Takkinen 2023-05-02 05:28:30 UTC
Created attachment 150496 [details] [review]
Bug 32993: Holds priority changed incorrectly with dropdown  selector

Test Plan:
1) Find record with at least 3 holds.
2) Change first holds priority as 2, Priority is changed to 3.
3) Try to change priority back to 1, Priority is changed to 2.
4) Apply this patch
5) Reload the page
2) Change first holds priority as 2, Priority is changed to 2.
3) Try to change priority back to 1, Priority is changed to 1.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi>
Comment 4 Hinemoea Viault 2023-05-08 16:24:18 UTC
Created attachment 150803 [details] [review]
Bug 32993: Holds priority changed incorrectly with dropdown selector

Test Plan:
1) Find record with at least 3 holds.
2) Change first holds priority as 2, Priority is changed to 3.
3) Try to change priority back to 1, Priority is changed to 2.
4) Apply this patch
5) Reload the page
2) Change first holds priority as 2, Priority is changed to 2.
3) Try to change priority back to 1, Priority is changed to 1.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi>
Signed-off-by: Hinemoea Viault <hinemoea.viault@inlibro.com>
Comment 5 Marcel de Rooy 2023-05-12 09:49:40 UTC
Created attachment 151128 [details] [review]
Bug 32993: Holds priority changed incorrectly with dropdown selector

Test Plan:
1) Find record with at least 3 holds.
2) Change first holds priority as 2, Priority is changed to 3.
3) Try to change priority back to 1, Priority is changed to 2.
4) Apply this patch
5) Reload the page
2) Change first holds priority as 2, Priority is changed to 2.
3) Try to change priority back to 1, Priority is changed to 1.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi>
Signed-off-by: Hinemoea Viault <hinemoea.viault@inlibro.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 6 Tomás Cohen Arazi (tcohen) 2023-05-12 14:21:00 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 7 Matt Blenkinsop 2023-05-15 13:00:30 UTC
Nice work everyone!

Pushed to stable for 22.11.x
Comment 8 Lucas Gass (lukeg) 2023-06-15 19:31:44 UTC
Backported to 22.05.x for upcoming 22.05.14
Comment 9 Danyon Sewell 2023-07-25 00:17:04 UTC
Backported to 21.11.x for upcoming 21.11.22