| Summary: | Click handler to show QR code in OPAC lacks preventDefault | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Kyle M Hall (khall) <kyle> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | arthur.suzuki, kyle, lucas, wainuiwitikapark |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.04,22.05.11, 21.11.19
|
|
| Circulation function: | |||
| Bug Depends on: | 23566 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 32999: Click handler to show QR code in OPAC lacks preventDefault
Bug 32999: Click handler to show QR code in OPAC lacks preventDefault Bug 32999: Click handler to show QR code in OPAC lacks preventDefault |
||
|
Description
Owen Leonard
2023-02-17 16:06:58 UTC
Created attachment 146857 [details] [review] Bug 32999: Click handler to show QR code in OPAC lacks preventDefault This patch adds "preventDefault()" to the click handler for showing the bibliographic detail QR code. This prevents the page from scrolling to the top when the user clicks the link. To test, apply the patch and make sure the OPACDetailQRCode system preference is enabled. Locate a bibliographic record and view the detail page. If necessary, reduce the size of your browser window so that you have to scroll down a bit to bring the "Send to device" menu item into view in the sidebar. Click the link to confirm that it shows the QR code and that the page doesn't jump to the top. Created attachment 146869 [details] [review] Bug 32999: Click handler to show QR code in OPAC lacks preventDefault This patch adds "preventDefault()" to the click handler for showing the bibliographic detail QR code. This prevents the page from scrolling to the top when the user clicks the link. To test, apply the patch and make sure the OPACDetailQRCode system preference is enabled. Locate a bibliographic record and view the detail page. If necessary, reduce the size of your browser window so that you have to scroll down a bit to bring the "Send to device" menu item into view in the sidebar. Click the link to confirm that it shows the QR code and that the page doesn't jump to the top. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 146900 [details] [review] Bug 32999: Click handler to show QR code in OPAC lacks preventDefault This patch adds "preventDefault()" to the click handler for showing the bibliographic detail QR code. This prevents the page from scrolling to the top when the user clicks the link. To test, apply the patch and make sure the OPACDetailQRCode system preference is enabled. Locate a bibliographic record and view the detail page. If necessary, reduce the size of your browser window so that you have to scroll down a bit to bring the "Send to device" menu item into view in the sidebar. Click the link to confirm that it shows the QR code and that the page doesn't jump to the top. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master for 23.05. Nice work everyone, thanks! Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release Backported to 22.05.x for upcoming 22.05.11 applied to 21.11.x for 21.11.19 Not backported to 21.05.x |