Bug 33004

Summary: Add VENDOR_TYPE to default authorised value categories
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: System AdministrationAssignee: Katrin Fischer <katrin.fischer>
Status: RESOLVED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: caroline.cyr-la-rose, gmcharlt
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.04
Bug Depends on: 31017    
Bug Blocks:    
Attachments: Bug 33004: Add VENDOR_TYPE to default authorised value categories
Bug 33004: Add VENDOR_TYPE to default authorised value categories
Bug 33004: Add VENDOR_TYPE to default authorised value categories

Description Katrin Fischer 2023-02-18 10:12:14 UTC
On a fresh installation we are missing the VENDOR_TYPE authorised value category.
Comment 1 Katrin Fischer 2023-02-18 11:04:17 UTC
Created attachment 146912 [details] [review]
Bug 33004: Add VENDOR_TYPE to default authorised value categories

To test:
* Go to administration > authorised values
* Verify that VENDOR_TYPE doesn't show in the list
* Apply patch
* Run database update
* Verify that VENDOR_TYPE does now appear and has a nice
  description (not added by this patch)
* Bonus: start over and run the web installer, VENDOR_TYPE
  should now be already there
Comment 2 Owen Leonard 2023-02-18 17:46:34 UTC
Created attachment 146928 [details] [review]
Bug 33004: Add VENDOR_TYPE to default authorised value categories

To test:
* Go to administration > authorised values
* Verify that VENDOR_TYPE doesn't show in the list
* Apply patch
* Run database update
* Verify that VENDOR_TYPE does now appear and has a nice
  description (not added by this patch)
* Bonus: start over and run the web installer, VENDOR_TYPE
  should now be already there

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Caroline Cyr La Rose 2023-02-20 15:20:32 UTC
To RMs - please backport to 22.11 since the vendor_type functionality was introduced in that version
Comment 4 Jonathan Druart 2023-02-23 09:36:39 UTC
Created attachment 147205 [details] [review]
Bug 33004: Add VENDOR_TYPE to default authorised value categories

To test:
* Go to administration > authorised values
* Verify that VENDOR_TYPE doesn't show in the list
* Apply patch
* Run database update
* Verify that VENDOR_TYPE does now appear and has a nice
  description (not added by this patch)
* Bonus: start over and run the web installer, VENDOR_TYPE
  should now be already there

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 5 Tomás Cohen Arazi 2023-02-27 16:07:16 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 6 Jacob O'Mara 2023-03-01 16:51:35 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.