|
Description
Owen Leonard
2023-02-18 15:51:33 UTC
Created attachment 146923 [details] [review] Bug 33006: Use template wrapper for breadcrumbs: Administration part 1 This patch updates several administration templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. Administration -> Administration home page - Under "Additional parameters" -> Additional fields -> View, create, edit -> Advanced editor shortcuts -> Audio alerts - Under "Acquisition parameters" -> Budgets -> Add fund -> Close fund -> Budget details -> Planning -> Create, edit, duplicate - Under "Catalog" -> Authority types -> MARC structure -> New, edit, delete -> "Actions" -> Subfields -> Edit, delete Acquisitions -> Vendor -> Contracts - View, edit, delete Created attachment 146924 [details] [review] Bug 33006: Use template wrapper for breadcrumbs: Administration part 1 This patch updates several administration templates so that they use the new WRAPPER for displaying breadcrumbs. Note: The patch includes indentation changes, so ignore whitespace when viewing the diff. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. Administration -> Administration home page - Under "Additional parameters" -> Additional fields -> View, create, edit -> Advanced editor shortcuts -> Audio alerts - Under "Acquisition parameters" -> Budgets -> Add fund -> Close fund -> Budget details -> Planning -> Create, edit, duplicate - Under "Catalog" -> Authority types -> MARC structure -> New, edit, delete -> "Actions" -> Subfields -> Edit, delete Acquisitions -> Vendor -> Contracts - View, edit, delete Created attachment 147092 [details] [review] Bug 33006: Use template wrapper for breadcrumbs: Administration part 1 This patch updates several administration templates so that they use the new WRAPPER for displaying breadcrumbs. Note: The patch includes indentation changes, so ignore whitespace when viewing the diff. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. Administration -> Administration home page - Under "Additional parameters" -> Additional fields -> View, create, edit -> Advanced editor shortcuts -> Audio alerts - Under "Acquisition parameters" -> Budgets -> Add fund -> Close fund -> Budget details -> Planning -> Create, edit, duplicate - Under "Catalog" -> Authority types -> MARC structure -> New, edit, delete -> "Actions" -> Subfields -> Edit, delete Acquisitions -> Vendor -> Contracts - View, edit, delete Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 147338 [details] [review] Bug 33006: (follow-up) Add spans for translatability This patch finds places in the updated breadcrumbs markup where a translatable string is isolated in a way that makes it hard for the translation script to find it, and wraps these strings with <span> This patch also modifies some of the templates to simplify the logic controlling how different elements of the breadcrumbs are shown or not. This patch also modifies another problematic set of strings in auth_tag_structure.tt outside the breadcrumbs. Created attachment 149053 [details] [review] Bug 33006: (follow-up) Add spans for translatability This patch finds places in the updated breadcrumbs markup where a translatable string is isolated in a way that makes it hard for the translation script to find it, and wraps these strings with <span> This patch also modifies some of the templates to simplify the logic controlling how different elements of the breadcrumbs are shown or not. This patch also modifies another problematic set of strings in auth_tag_structure.tt outside the breadcrumbs. Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com> Lovely! Created attachment 149338 [details] [review] Bug 33006: Use template wrapper for breadcrumbs: Administration part 1 This patch updates several administration templates so that they use the new WRAPPER for displaying breadcrumbs. Note: The patch includes indentation changes, so ignore whitespace when viewing the diff. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. Administration -> Administration home page - Under "Additional parameters" -> Additional fields -> View, create, edit -> Advanced editor shortcuts -> Audio alerts - Under "Acquisition parameters" -> Budgets -> Add fund -> Close fund -> Budget details -> Planning -> Create, edit, duplicate - Under "Catalog" -> Authority types -> MARC structure -> New, edit, delete -> "Actions" -> Subfields -> Edit, delete Acquisitions -> Vendor -> Contracts - View, edit, delete Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 149339 [details] [review] Bug 33006: (follow-up) Add spans for translatability This patch finds places in the updated breadcrumbs markup where a translatable string is isolated in a way that makes it hard for the translation script to find it, and wraps these strings with <span> This patch also modifies some of the templates to simplify the logic controlling how different elements of the breadcrumbs are shown or not. This patch also modifies another problematic set of strings in auth_tag_structure.tt outside the breadcrumbs. Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.05. Nice work everyone, thanks! Nice work, thanks everyone! Pushed to 22.11.x for the next release. |