Summary: | CheckinSlip doesn't return checkins if checkout library and checkin library differ | ||
---|---|---|---|
Product: | Koha | Reporter: | Emmi Takkinen <emmi.takkinen> |
Component: | Tools | Assignee: | Emmi Takkinen <emmi.takkinen> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | kebliss, lucas |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.07
|
|
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 33641 | ||
Attachments: |
Bug 33010: Do not filter checkins with logged in patrons branch in printslip.pl
Bug 33010: Do not filter checkins with logged in patrons branch in printslip.pl Bug 33010: Do not filter checkins with logged in patrons branch in printslip.pl |
Description
Emmi Takkinen
2023-02-20 07:49:43 UTC
Created attachment 146943 [details] [review] Bug 33010: Do not filter checkins with logged in patrons branch in printslip.pl If one tries to print checkin slip for checkins that have been checked out from different branch, list of checkins is empty. One has to change their branch as checkout library to be able to print checkins. This happens because we filter (or rather search) patrons old checkouts with logged in patrons branch. This patch removes this search so that checkout are filtered using just filter_by_todays_checkins. To test: 1. Checkout items for patron from branch A. 2. Switch to branch B and checkin items. 3. Print checkin slip. => Checkins list is empty. 4. Switch back to branch A. 5. Print checkin slip again. => Checkins are printed. 6. Apply this patch, restart services if needed. 7. Switch back to branch B and print checkin slip. => Checkins should now print. Sponsored-by: Koha-Suomi Oy Hm, I think the idea might have been to limit on the checkin library, as this is the library that will print on the slip. But I gather it's currently looking at the checkout library? (In reply to Katrin Fischer from comment #2) > Hm, I think the idea might have been to limit on the checkin library, as > this is the library that will print on the slip. But I gather it's currently > looking at the checkout library? Yes, it's using branch for logged in patron but looking at the checkout library. It seems this happens because (old_)reserves branchcode column is filled with info of the checkout library. If we had returnbranch column or something like that, we could search with it. Created attachment 150174 [details] [review] Bug 33010: Do not filter checkins with logged in patrons branch in printslip.pl If one tries to print checkin slip for checkins that have been checked out from different branch, list of checkins is empty. One has to change their branch as checkout library to be able to print checkins. This happens because we filter (or rather search) patrons old checkouts with logged in patrons branch. This patch removes this search so that checkout are filtered using just filter_by_todays_checkins. To test: 1. Checkout items for patron from branch A. 2. Switch to branch B and checkin items. 3. Print checkin slip. => Checkins list is empty. 4. Switch back to branch A. 5. Print checkin slip again. => Checkins are printed. 6. Apply this patch, restart services if needed. 7. Switch back to branch B and print checkin slip. => Checkins should now print. Sponsored-by: Koha-Suomi Oy Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 150429 [details] [review] Bug 33010: Do not filter checkins with logged in patrons branch in printslip.pl If one tries to print checkin slip for checkins that have been checked out from different branch, list of checkins is empty. One has to change their branch as checkout library to be able to print checkins. This happens because we filter (or rather search) patrons old checkouts with logged in patrons branch. This patch removes this search so that checkout are filtered using just filter_by_todays_checkins. To test: 1. Checkout items for patron from branch A. 2. Switch to branch B and checkin items. 3. Print checkin slip. => Checkins list is empty. 4. Switch back to branch A. 5. Print checkin slip again. => Checkins are printed. 6. Apply this patch, restart services if needed. 7. Switch back to branch B and print checkin slip. => Checkins should now print. Sponsored-by: Koha-Suomi Oy Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to master for 23.05. Nice work everyone, thanks! It would be very nice if this one could be backported into 22.11. Nice work everyone! Pushed to stable for 22.11.x |