Bug 33041

Summary: Use process_tt in C4::Serial::NewIssue
Product: Koha Reporter: Kyle M Hall (khall) <kyle>
Component: Architecture, internals, and plumbingAssignee: Kyle M Hall (khall) <kyle>
Status: RESOLVED FIXED QA Contact: Marcel de Rooy <m.de.rooy>
Severity: enhancement    
Priority: P5 - low CC: david, m.de.rooy
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00
Circulation function:
Bug Depends on: 33030, 33039    
Bug Blocks:    
Attachments: Bug 33041: Use process_tt in C4::Serial::NewIssue
Bug 33041: Use process_tt in C4::Serial::NewIssue
Bug 33041: Use process_tt in C4::Serial::NewIssue

Description Kyle M Hall (khall) 2023-02-22 16:46:50 UTC
Bug 33030 implements a new helper subroutine to standardize processing of Template Toolkit syntax outside slips and notices. We should use this subroutine in C4::Serial::NewIssue
Comment 1 Kyle M Hall (khall) 2023-02-22 16:48:23 UTC
Created attachment 147175 [details] [review]
Bug 33041: Use process_tt in C4::Serial::NewIssue

Bug 33030 implements a new helper subroutine to standardize processing of Template Toolkit syntax outside slips and notices. We should use this subroutine in C4::Serial::NewIssue

Test Plan:
1) Apply this patch
2) prove t/db_dependent/Koha/Items.t
Comment 2 David Nind 2023-05-02 11:12:08 UTC
Created attachment 150515 [details] [review]
Bug 33041: Use process_tt in C4::Serial::NewIssue

Bug 33030 implements a new helper subroutine to standardize processing of Template Toolkit syntax outside slips and notices. We should use this subroutine in C4::Serial::NewIssue

Test Plan:
1) Apply this patch
2) prove t/db_dependent/Koha/Items.t

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2023-05-02 11:13:27 UTC
Testing notes (using KTD):

1. After applying the patch and dependencies, run updatedatabase (for 33039).
Comment 4 Marcel de Rooy 2023-07-07 09:53:56 UTC
Created attachment 153144 [details] [review]
Bug 33041: Use process_tt in C4::Serial::NewIssue

Bug 33030 implements a new helper subroutine to standardize processing of Template Toolkit syntax outside slips and notices. We should use this subroutine in C4::Serial::NewIssue

Test Plan:
1) Apply this patch
2) prove t/db_dependent/Koha/Items.t

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 5 Tomás Cohen Arazi (tcohen) 2023-07-18 17:08:51 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!