Bug 33045

Summary: Use process_tt in C4::Record::marcrecord2csv
Product: Koha Reporter: Kyle M Hall (khall) <kyle>
Component: Architecture, internals, and plumbingAssignee: Kyle M Hall (khall) <kyle>
Status: RESOLVED FIXED QA Contact: Marcel de Rooy <m.de.rooy>
Severity: enhancement    
Priority: P5 - low CC: fridolin.somers, m.de.rooy
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00
Circulation function:
Bug Depends on: 33030    
Bug Blocks:    
Attachments: Bug 33045: Use process_tt in C4::Record::marcrecord2csv
Bug 33045: Use process_tt in C4::Record::marcrecord2csv
Bug 33045: Use process_tt in C4::Record::marcrecord2csv
Bug 33045: Fix shebang of marcrecord2csv.t

Description Kyle M Hall (khall) 2023-02-22 18:16:15 UTC
Bug 33030 implements a new helper subroutine to standardize processing of Template Toolkit syntax outside slips and notices. We should use this subroutine in marcrecord2csv.
Comment 1 Kyle M Hall (khall) 2023-02-22 19:49:04 UTC
Created attachment 147181 [details] [review]
Bug 33045: Use process_tt in C4::Record::marcrecord2csv

Bug 33030 implements a new helper subroutine to standardize processing of Template Toolkit syntax outside slips and notices. We should use this subroutine in marcrecord2csv.

Test Plan:
1) Apply this patch
2) prove t/db_dependent/Record/marcrecord2csv.t
Comment 2 David Nind 2023-05-02 01:52:21 UTC
Created attachment 150493 [details] [review]
Bug 33045: Use process_tt in C4::Record::marcrecord2csv

Bug 33030 implements a new helper subroutine to standardize processing of Template Toolkit syntax outside slips and notices. We should use this subroutine in marcrecord2csv.

Test Plan:
1) Apply this patch
2) prove t/db_dependent/Record/marcrecord2csv.t

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Marcel de Rooy 2023-09-15 09:29:02 UTC
Created attachment 155652 [details] [review]
Bug 33045: Use process_tt in C4::Record::marcrecord2csv

Bug 33030 implements a new helper subroutine to standardize processing of Template Toolkit syntax outside slips and notices. We should use this subroutine in marcrecord2csv.

Test Plan:
1) Apply this patch
2) prove t/db_dependent/Record/marcrecord2csv.t

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Marcel de Rooy 2023-09-15 09:29:05 UTC
Created attachment 155653 [details] [review]
Bug 33045: Fix shebang of marcrecord2csv.t

Resolves:
bash: t/db_dependent/Record/marcrecord2csv.t: /usr/bin/perl;: bad interpreter: No such file or directory

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 5 Tomás Cohen Arazi (tcohen) 2023-09-15 14:58:26 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 6 Fridolin Somers 2023-09-18 08:31:49 UTC
Depends on Bug 33030 not in 23.05.x