Summary: | Koha/Acquisition/Order.t is failing randomly | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Test Suite | Assignee: | Kyle M Hall (khall) <kyle> |
Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
Severity: | normal | ||
Priority: | P5 - low | CC: | kyle, lucas, tomascohen |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.04
|
|
Circulation function: | |||
Bug Depends on: | 20256 | ||
Bug Blocks: | 25551 | ||
Attachments: |
Bug 33054: Remove use of can_edit_items
Bug 33054: Fix unit tests |
Description
Jonathan Druart
2023-02-23 13:57:31 UTC
Created attachment 147234 [details] [review] Bug 33054: Remove use of can_edit_items Test Plan: 1) Apply this patch 2) prove t/db_dependent/Koha/Acquisition/Order.t 3) git grep "can_edit_item(" should return no results Did you understand why the failure was occurring randomly? Created attachment 147396 [details] [review] Bug 33054: Fix unit tests This patch fixes the tests by making sure: - The branch in userenv matches the home/holding branch so there are no circ rules getting in the middle - Gives the user superlibrarian permissions for the same reasons above. To test: 1. Run: $ ktd --shell k$ for i in $(seq 1 20 ); do prove t/db_dependent/Koha/Acquisition/Order.t ; done => FAIL: Notice it fails quite often. You can ctrl+c to interrupt once it has failed at least once. 2. Apply this patch 3. Repeat 1 => SUCCESS: it doesn't fail a single time 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Pushed to master for 23.05. Nice work everyone, thanks! Nice work everyone! Pushed to stable for 22.11.x Missing dependencies for 22.05.x, no backport. |