| Summary: | SIP2 adding incorrect fines blocked message | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | SIP2 | Assignee: | Nick Clemens (kidclamp) <nick> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | major | ||
| Priority: | P5 - low | CC: | arthur.suzuki, enica, lucas, martin.renvoize, tomascohen, wainuiwitikapark |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.04,22.05.11,21.11.19
|
|
| Circulation function: | |||
| Bug Depends on: | 32624 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 33055: (bug 32624 follow-up) Unit tests
Bug 33055: (bug 32624 follow-up) Don't send a screen message if not blocked Bug 33055: (bug 32624 follow-up) Unit tests Bug 33055: (bug 32624 follow-up) Don't send a screen message if not blocked Bug 33055: (bug 32624 follow-up) Unit tests Bug 33055: (bug 32624 follow-up) Don't send a screen message if not blocked |
||
|
Description
Nick Clemens (kidclamp)
2023-02-23 15:15:06 UTC
Created attachment 147258 [details] [review] Bug 33055: (bug 32624 follow-up) Unit tests Created attachment 147259 [details] [review] Bug 33055: (bug 32624 follow-up) Don't send a screen message if not blocked To test: 0 - Apply first patch 1 - prove -v t/db_dependent/SIP/Patron.t 2 - It fails 3 - Apply second patch 4 - prove -v t/db_dependent/SIP/Patron.t 5 - It passes! Created attachment 147330 [details] [review] Bug 33055: (bug 32624 follow-up) Unit tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 147331 [details] [review] Bug 33055: (bug 32624 follow-up) Don't send a screen message if not blocked To test: 0 - Apply first patch 1 - prove -v t/db_dependent/SIP/Patron.t 2 - It fails 3 - Apply second patch 4 - prove -v t/db_dependent/SIP/Patron.t 5 - It passes! Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Damn.. annoyed I missed this at QA first time around :(. Working as expected now, Signing off. Created attachment 147507 [details] [review] Bug 33055: (bug 32624 follow-up) Unit tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 147508 [details] [review] Bug 33055: (bug 32624 follow-up) Don't send a screen message if not blocked To test: 0 - Apply first patch 1 - prove -v t/db_dependent/SIP/Patron.t 2 - It fails 3 - Apply second patch 4 - prove -v t/db_dependent/SIP/Patron.t 5 - It passes! Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Pushed to master for 23.05. Nice work everyone, thanks! Nice work everyone! Pushed to stable for 22.11.x Backported to 22.05.x for upcoming 22.05.11 applied to 21.11 for 21.11.19 Not backported to 21.05.x |