| Summary: | Fix yes/no setting to 1/0 in system preference YAML files | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
| Component: | System Administration | Assignee: | Katrin Fischer <katrin.fischer> |
| Status: | CLOSED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | gmcharlt, lucas, martin.renvoize |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.04
|
|
| Circulation function: | |||
| Bug Depends on: | 20058 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 33060: Fix yes/no setting to 1/0 in system preference YAML files
Bug 33060: Fix yes/no setting to 1/0 in system preference YAML files Bug 33060: Fix yes/no setting to 1/0 in system preference YAML files |
||
|
Description
Katrin Fischer
2023-02-23 22:15:50 UTC
Created attachment 147274 [details] [review] Bug 33060: Fix yes/no setting to 1/0 in system preference YAML files Boolean system preferences need to use 1 and 0 for true and false, not yes and no now. This fixes a few occurences that have been added in the last release: * EnableItemGroups * EnableItemGroupHolds * ArticleRequestsOpacHostRedirection * UseLocationAsAQInSIP To test: * Make sure these preferences save to the db as 0/1 as expected. Created attachment 147432 [details] [review] Bug 33060: Fix yes/no setting to 1/0 in system preference YAML files Boolean system preferences need to use 1 and 0 for true and false, not yes and no now. This fixes a few occurences that have been added in the last release: * EnableItemGroups * EnableItemGroupHolds * ArticleRequestsOpacHostRedirection * UseLocationAsAQInSIP To test: * Make sure these preferences save to the db as 0/1 as expected. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 148230 [details] [review] Bug 33060: Fix yes/no setting to 1/0 in system preference YAML files Boolean system preferences need to use 1 and 0 for true and false, not yes and no now. This fixes a few occurences that have been added in the last release: * EnableItemGroups * EnableItemGroupHolds * ArticleRequestsOpacHostRedirection * UseLocationAsAQInSIP To test: * Make sure these preferences save to the db as 0/1 as expected. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Does as describe so Passing QA. Does raise a minor questiont though.. we have 'default:yes' a few times in authorities.pref where they relate to 0|1 preferences.. should those now be 'default:1' ? Pushed to master for 23.05. Nice work everyone, thanks! Nice work everyone! Pushed to stable for 22.11.x Doesn't apply cleanly to 22.05.x, no backport. |