Summary: | Duplicated reports should maintain subgroup of original | ||
---|---|---|---|
Product: | Koha | Reporter: | Andrew Fuerste-Henry <andrew> |
Component: | Reports | Assignee: | Katrin Fischer <katrin.fischer> |
Status: | CLOSED FIXED | QA Contact: | Lucas Gass (lukeg) <lucas> |
Severity: | normal | ||
Priority: | P5 - low | CC: | arthur.suzuki, lucas, sally.healey, wainuiwitikapark |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.04,22.05.12,21.11.20
|
|
Circulation function: | |||
Attachments: |
Bug 33063: Make sure correct subgroup is pre-selected when duplicating reports
Bug 33063: Make sure correct subgroup is pre-selected when duplicating reports Bug 33063: Make sure correct subgroup is pre-selected when duplicating reports |
Description
Andrew Fuerste-Henry
2023-02-24 14:32:25 UTC
Created attachment 147475 [details] [review] Bug 33063: Make sure correct subgroup is pre-selected when duplicating reports When the 'Duplicate' option for reports was used, the all options would be copied correctly to the new report, but the report sub group. In this case the templates were created correctly, but the JavaScript to create the correct pull downs for each group, overwrote the the selection. To test: * Create a some reports with different groups and subgroups and without * 'Duplicate' your reports and verify that the sub group will always stay empty * Apply patch * Verify the correct sub group is now always selected * Edit/Add some reports to make sure the group/subgroup controls still work as expected *** Bug 33062 has been marked as a duplicate of this bug. *** Created attachment 147819 [details] [review] Bug 33063: Make sure correct subgroup is pre-selected when duplicating reports When the 'Duplicate' option for reports was used, the all options would be copied correctly to the new report, but the report sub group. In this case the templates were created correctly, but the JavaScript to create the correct pull downs for each group, overwrote the the selection. To test: * Create a some reports with different groups and subgroups and without * 'Duplicate' your reports and verify that the sub group will always stay empty * Apply patch * Verify the correct sub group is now always selected * Edit/Add some reports to make sure the group/subgroup controls still work as expected Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Works as described, thanks for the patch. (In reply to Sally from comment #4) > Works as described, thanks for the patch. Thx for testing :) Changes look good, QA script is happy. PQA. Created attachment 147961 [details] [review] Bug 33063: Make sure correct subgroup is pre-selected when duplicating reports When the 'Duplicate' option for reports was used, the all options would be copied correctly to the new report, but the report sub group. In this case the templates were created correctly, but the JavaScript to create the correct pull downs for each group, overwrote the the selection. To test: * Create a some reports with different groups and subgroups and without * 'Duplicate' your reports and verify that the sub group will always stay empty * Apply patch * Verify the correct sub group is now always selected * Edit/Add some reports to make sure the group/subgroup controls still work as expected Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Pushed to master for 23.05. Nice work everyone, thanks! Nice work everyone! Pushed to stable for 22.11.x Backported to 22.05.x for upcoming 22.05.12 applied to 21.11.x for 21.11.20 Not backported to 21.05.x |