Bug 33076

Summary: Add context to "Quotes"
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: I18N/L10NAssignee: Katrin Fischer <katrin.fischer>
Status: CLOSED FIXED QA Contact: Martin Renvoize (ashimema) <martin.renvoize>
Severity: minor    
Priority: P5 - low CC: arthur.suzuki, caroline.cyr-la-rose, f.demians, lucas, martin.renvoize, matt.blenkinsop, tomascohen
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.04,22.05.12
Circulation function:
Attachments: Bug 33076: Add context to "Quotes"
Bug 33076: Add context to "Quotes"
Bug 33076: Add context to "Quotes"
Bug 33076: (QA follow-up) Update context hint to "EDIFACT message QUOTE"

Description Katrin Fischer 2023-02-27 11:15:12 UTC
In German at least, a quote in the sense of a "quote of the day" and a quote for something I want to buy/order are different thing that require different translation. It would be great if we could add context to those labels where just "Quotes" is used.


koha-tmpl/intranet-tmpl/prog/en/modules/admin/edi_accounts.tt:322 koha-tmpl/intranet-tmpl/prog/en/modules/tools/quotes.tt:107
Comment 1 Katrin Fischer 2023-02-27 22:24:26 UTC
Created attachment 147474 [details] [review]
Bug 33076: Add context to "Quotes"

A quote as a part of quoted text and a quote as
part of the acquisition process need to be
translated differently at least in German.
This patch adds context to the terms, so we can
do that.

To test:
* Go to Tools > Quote editor
* Verify the heading of the page reads "Quotes"
* Enable EDIFACT system preference
* Go to Administration > EDI accounts
* Add a new account save
* Verify the table heading reads "Quotes"
* Apply patch - nothing should change

Verify the translation process:
* Run: gulp po:update --lang de-DE
* Verify the "Quotes" appear now separated by
  different context in
  misc/translator/po/de-DE-messages.po
Comment 2 Owen Leonard 2023-02-28 16:39:21 UTC
Created attachment 147505 [details] [review]
Bug 33076: Add context to "Quotes"

A quote as a part of quoted text and a quote as
part of the acquisition process need to be
translated differently at least in German.
This patch adds context to the terms, so we can
do that.

To test:
* Go to Tools > Quote editor
* Verify the heading of the page reads "Quotes"
* Enable EDIFACT system preference
* Go to Administration > EDI accounts
* Add a new account save
* Verify the table heading reads "Quotes"
* Apply patch - nothing should change

Verify the translation process:
* Run: gulp po:update --lang de-DE
* Verify the "Quotes" appear now separated by
  different context in
  misc/translator/po/de-DE-messages.po

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Martin Renvoize (ashimema) 2023-03-15 17:51:47 UTC
Created attachment 148234 [details] [review]
Bug 33076: Add context to "Quotes"

A quote as a part of quoted text and a quote as
part of the acquisition process need to be
translated differently at least in German.
This patch adds context to the terms, so we can
do that.

To test:
* Go to Tools > Quote editor
* Verify the heading of the page reads "Quotes"
* Enable EDIFACT system preference
* Go to Administration > EDI accounts
* Add a new account save
* Verify the table heading reads "Quotes"
* Apply patch - nothing should change

Verify the translation process:
* Run: gulp po:update --lang de-DE
* Verify the "Quotes" appear now separated by
  different context in
  misc/translator/po/de-DE-messages.po

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize (ashimema) 2023-03-15 17:53:06 UTC
I think this is OK.. I wasn't 100% sure about the EDI template change.. QUOTES is a type of edi message in this context.. but it may well be translated too...?

Anyway.. I reckon we can PQA.
Comment 5 Caroline Cyr La Rose 2023-03-15 18:03:26 UTC
Martin,
Do you mean that EDI's "Quotes" should have it's own context vs other "price submissions"? Or that the context "price submissions" is not correct at all?
Caroline
Comment 6 Katrin Fischer 2023-03-15 22:43:23 UTC
We could also make it "EDIFACT message QUOTE" maybe?
Comment 7 Martin Renvoize (ashimema) 2023-03-16 09:28:28 UTC
(In reply to Katrin Fischer from comment #6)
> We could also make it "EDIFACT message QUOTE" maybe?

That makes sense, I think. I wasn't entirely sure, really.. it's a technical term as a posed to a accounting one in this case so hopefully it'll help the translators understand.
Comment 8 Tomás Cohen Arazi (tcohen) 2023-03-16 19:31:39 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 9 Matt Blenkinsop 2023-03-17 17:02:56 UTC
Nice work everyone!

Pushed to stable for 22.11.x
Comment 10 Katrin Fischer 2023-03-17 21:47:30 UTC
Created attachment 148388 [details] [review]
Bug 33076: (QA follow-up) Update context hint to "EDIFACT message QUOTE"

As discussed on the bug, this updates the hint to make it
easier for translators to decide on the correct translation.
Comment 11 Katrin Fischer 2023-03-17 21:48:14 UTC
Tomas, could you push this small follow-up?
Comment 12 Tomás Cohen Arazi (tcohen) 2023-03-20 12:19:51 UTC
Follow-up pushed to master.
Comment 13 Matt Blenkinsop 2023-03-21 16:34:00 UTC
Follow-up pushed to 22.11.x, keywords removed
Comment 14 Lucas Gass (lukeg) 2023-04-21 16:45:53 UTC
Backported to 22.05.x for upcoming 22.05.12
Comment 15 Arthur Suzuki 2023-05-03 18:31:30 UTC
This bug doesn't apply fine on 21.11.x... can you provide a backport if needed?
Thx!