| Summary: | page-sections are missing in the account line details page | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
| Component: | Staff interface | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | gmcharlt, lucas, oleonard |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.04
|
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 31757 | ||
| Attachments: |
Bug 33090: Add page-section to accountline-details
Bug 33090: Add page-section to accountline-details Bug 33090: Add page-section to accountline-details |
||
|
Description
Martin Renvoize (ashimema)
2023-02-28 16:33:41 UTC
Created attachment 147506 [details] [review] Bug 33090: Add page-section to accountline-details This patch adds page-section containers to the accountlines details display page. I'm not really sure I like the appearance yet.. input welcome. Thx for filing :) Created attachment 147561 [details] [review] Bug 33090: Add page-section to accountline-details This patch adds page-section containers to the accountlines details display page. Note: This patch contains whitespace changes, so use diff accordingly. To test, apply the patch and locate a patron with charges on their account (lost item fee, account renewal fee, overdue fine, etc). - From the patron detail page, click the "Accounting" tab in the sidebar menu. - Click the "Transactions" tab. - Click the "Details" button for an individual charge. - On the transaction detail page, confirm that the page sections look correct. Signed-off-by: Owen Leonard <oleonard@myacpl.org> I think this change is logical and consistent. To keep things muddy I fixed some indentation and added markup comments. And wrote a test plan. I hope that's okay! Created attachment 147757 [details] [review] Bug 33090: Add page-section to accountline-details This patch adds page-section containers to the accountlines details display page. Note: This patch contains whitespace changes, so use diff accordingly. To test, apply the patch and locate a patron with charges on their account (lost item fee, account renewal fee, overdue fine, etc). - From the patron detail page, click the "Accounting" tab in the sidebar menu. - Click the "Transactions" tab. - Click the "Details" button for an individual charge. - On the transaction detail page, confirm that the page sections look correct. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.05. Nice work everyone, thanks! Nice work everyone! Pushed to stable for 22.11.x Not needed in 22.05.x, no backport |