|
Description
Janusz Kaczmarek
2023-02-28 18:17:30 UTC
Created attachment 147519 [details] [review] Bug 33093 - (Bug 27546 follow-up) With ES searching within results does not work for 'Keyword' and 'Keyword as phrase' The feature of searching within search results in librarian has some problems with with elastic: 'Keyword' and 'Keyword as phrase' searches give no results. This is because elastic is unaware of the search field 'kw' and 'kw' is not transformed nor removed for limits. Test plan ========= 1. Have a Koha instance with reasonable number of biblio records 1. Set SearchEngine to Elasticsearch 3. In librarian interface, perform a search that would give you a list of results 4. With the new search box 'Search within results', having 'Keyword' and 'Keyword as phrase' active, try to perform a search within search results with a term that should give you some results 5. You should get no results 6. Apply the patch 7. Repeat steps 3 and 4 8. You should get expected results. Note the difference between 'Keyword' and 'Keyword as phrase' in results 9. Sign off Created attachment 147520 [details] [review] Bug 33093 - (Bug 27546 follow-up) With ES searching within results does not work for 'Keyword' and 'Keyword as phrase' The feature of searching within search results in librarian interface has some problems with with elastic: 'Keyword' and 'Keyword as phrase' searches give no results. This is because elastic is unaware of the search field 'kw' and 'kw' is not transformed nor removed for limits. Test plan ========= 1. Have a Koha instance with reasonable number of biblio records 1. Set SearchEngine to Elasticsearch 3. In librarian interface, perform a search that would give you a list of results 4. With the new search box 'Search within results', having 'Keyword' and 'Keyword as phrase' active, try to perform a search within search results with a term that should give you some results 5. You should get no results 6. Apply the patch 7. Repeat steps 3 and 4 8. You should get expected results. Note the difference between 'Keyword' and 'Keyword as phrase' in results 9. Sign off Created attachment 149021 [details] [review] Bug 33093 - (Bug 27546 follow-up) With ES searching within results does not work for 'Keyword' and 'Keyword as phrase' The feature of searching within search results in librarian interface has some problems with with elastic: 'Keyword' and 'Keyword as phrase' searches give no results. This is because elastic is unaware of the search field 'kw' and 'kw' is not transformed nor removed for limits. Test plan ========= 1. Have a Koha instance with reasonable number of biblio records 1. Set SearchEngine to Elasticsearch 3. In librarian interface, perform a search that would give you a list of results 4. With the new search box 'Search within results', having 'Keyword' and 'Keyword as phrase' active, try to perform a search within search results with a term that should give you some results 5. You should get no results 6. Apply the patch 7. Repeat steps 3 and 4 8. You should get expected results. Note the difference between 'Keyword' and 'Keyword as phrase' in results 9. Sign off Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> *** Bug 33543 has been marked as a duplicate of this bug. *** Created attachment 149771 [details] [review] Bug 33093: (Bug 27546 follow-up) With ES searching within results does not work for 'Keyword' and 'Keyword as phrase' The feature of searching within search results in librarian interface has some problems with with elastic: 'Keyword' and 'Keyword as phrase' searches give no results. This is because elastic is unaware of the search field 'kw' and 'kw' is not transformed nor removed for limits. Test plan ========= 1. Have a Koha instance with reasonable number of biblio records 1. Set SearchEngine to Elasticsearch 3. In librarian interface, perform a search that would give you a list of results 4. With the new search box 'Search within results', having 'Keyword' and 'Keyword as phrase' active, try to perform a search within search results with a term that should give you some results 5. You should get no results 6. Apply the patch 7. Repeat steps 3 and 4 8. You should get expected results. Note the difference between 'Keyword' and 'Keyword as phrase' in results 9. Sign off Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> Signed-off-by: Nick <nick@bywatersolutions.com> This fixes the bug, it also improves handling of phrasing for keyword search - title and other limits are all quoted by default - which looks intentional, but this works as expected. I think we should open a follow-up to address limit phrasing at large and possible consolidate code - bug 33548 Pushed to master for 23.05. Nice work everyone, thanks! Nice work everyone! Pushed to stable for 22.11.x We should add a unit test to : t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t Missing dependencies for 22.05.x, no backport. |