Summary: | Text is white on white when hovering over pay/writeoff buttons in paycollect | ||
---|---|---|---|
Product: | Koha | Reporter: | Caroline Cyr La Rose <caroline.cyr-la-rose> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | jacob.omara, lucas |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.04
|
|
Circulation function: | |||
Attachments: |
Bug 33095: Text is white on white when hovering over pay/writeoff buttons in paycollect
Bug 33095: Text is white on white when hovering over pay/writeoff buttons in paycollect Bug 33095: Text is white on white when hovering over pay/writeoff buttons in paycollect |
Description
Caroline Cyr La Rose
2023-02-28 19:30:04 UTC
Created attachment 147577 [details] [review] Bug 33095: Text is white on white when hovering over pay/writeoff buttons in paycollect The "Make a payment" page uses unusual navigation for the switch between the "Pay" and "Write off" views: Bootstrap nav pills. The style on these is a little muddled because a mix of Bootstrap and custom CSS is at work. This patch adds some CSS specific to nav pills and removes some ambiguous CSS. Two links in the template get a dummy "#" href attribute to make them work better with default styles. To test, apply the patch and rebuild the staff interface CSS. - Locate a patron who has outstanding charges (lost item charge, account renewal fee, overdue fine, etc.). - From the patron checkout or detail page, click the "Accounting" tab in the left hand sidebar. - Click the "Pay" button on one of the oustanding charges. - On the "Pay an individual fine" page, confirm that there is a button and a link at the top of tab panel: "Pay" and "Write off." The "Pay" button should green with white text, the "Write off" button should be white with green text. - Click the "Write off" button and the styles of the links should be reversed. - Confirm that the CSS changes do not affect the appearance of the main navigation bar at the top of the page. Created attachment 147579 [details] [review] Bug 33095: Text is white on white when hovering over pay/writeoff buttons in paycollect The "Make a payment" page uses unusual navigation for the switch between the "Pay" and "Write off" views: Bootstrap nav pills. The style on these is a little muddled because a mix of Bootstrap and custom CSS is at work. This patch adds some CSS specific to nav pills and removes some ambiguous CSS. Two links in the template get a dummy "#" href attribute to make them work better with default styles. To test, apply the patch and rebuild the staff interface CSS. - Locate a patron who has outstanding charges (lost item charge, account renewal fee, overdue fine, etc.). - From the patron checkout or detail page, click the "Accounting" tab in the left hand sidebar. - Click the "Pay" button on one of the oustanding charges. - On the "Pay an individual fine" page, confirm that there is a button and a link at the top of tab panel: "Pay" and "Write off." The "Pay" button should green with white text, the "Write off" button should be white with green text. - Click the "Write off" button and the styles of the links should be reversed. - Confirm that the CSS changes do not affect the appearance of the main navigation bar at the top of the page. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> This is much much better than before, but I notice that here and in some other places we have yellow buttons with white font. The normal "main" button is yellow with black font, which I think has the better contrast. Created attachment 147748 [details] [review] Bug 33095: Text is white on white when hovering over pay/writeoff buttons in paycollect The "Make a payment" page uses unusual navigation for the switch between the "Pay" and "Write off" views: Bootstrap nav pills. The style on these is a little muddled because a mix of Bootstrap and custom CSS is at work. This patch adds some CSS specific to nav pills and removes some ambiguous CSS. Two links in the template get a dummy "#" href attribute to make them work better with default styles. To test, apply the patch and rebuild the staff interface CSS. - Locate a patron who has outstanding charges (lost item charge, account renewal fee, overdue fine, etc.). - From the patron checkout or detail page, click the "Accounting" tab in the left hand sidebar. - Click the "Pay" button on one of the oustanding charges. - On the "Pay an individual fine" page, confirm that there is a button and a link at the top of tab panel: "Pay" and "Write off." The "Pay" button should green with white text, the "Write off" button should be white with green text. - Click the "Write off" button and the styles of the links should be reversed. - Confirm that the CSS changes do not affect the appearance of the main navigation bar at the top of the page. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.05. Nice work everyone, thanks! Nice work, thanks everyone! Pushed to 22.11.x for the next release. Can't recreate in 22.05, won't backport. |