| Summary: | Add vendor link to ERM Licences | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Acquisitions | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | BLOCKED --- | QA Contact: | Katrin Fischer <katrin.fischer> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | jonathan.field, tomascohen |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 32968 | ||
| Bug Blocks: | 33465 | ||
| Attachments: |
Bug 33106: Add vendor link to ERM licenses
Bug 33106: Add vendor link to ERM licenses Bug 33106: Add vendor link to ERM licenses Bug 33106: Add vendor link to ERM licenses Bug 33106: Add vendor link to ERM licenses |
||
|
Description
Jonathan Druart
2023-03-01 10:02:31 UTC
Created attachment 147631 [details] [review] Bug 33106: Add vendor link to ERM licenses This patch adds a "Licenses" link in the acquisition module to link to the licenses defined in the ERM module. Test plan: - Create a vendor - Create some licenses in the ERM module, add some to the vendor previously created - Go to the detail page of the vendor in the acquisition module => Notice the new "Licenses" tab on the side bar => Notice that this tab does not appear if you do not have the permission to see licenses - Click on the new tab => Notice that you are redirected to the license list view, in the ERM module, with an automatic filter on the vendor Created attachment 148810 [details] [review] Bug 33106: Add vendor link to ERM licenses This patch adds a "Licenses" link in the acquisition module to link to the licenses defined in the ERM module. Test plan: - Create a vendor - Create some licenses in the ERM module, add some to the vendor previously created - Go to the detail page of the vendor in the acquisition module => Notice the new "Licenses" tab on the side bar => Notice that this tab does not appear if you do not have the permission to see licenses - Click on the new tab => Notice that you are redirected to the license list view, in the ERM module, with an automatic filter on the vendor With the latest patches applied I find that the link from the vendor to Licences always links to ALL licences, rather than filtering to the linked vendor. I also think it would be helpful if the link in the vendor ONLY displayed if the licence record is linked to a vendor. Right now, the Licence link displays on all vendor records if ERM is enabled. Libraries might find it annoying that the Licence link display of print book vendors that aren't linked in any way? So, the erm_licenses table has a vendor_id link. Only display the vendor link if this link exists in the db? Thanks Jonathan (In reply to Jonathan Field from comment #3) > With the latest patches applied I find that the link from the vendor to > Licences always links to ALL licences, rather than filtering to the linked > vendor. I am not recreating that. Did you try on a sandbox? Yes, on our sandbox I've asked Martin to create a sandbox and I did recreate the problem there. After we rebuilt the JS file it's now working: http://staff-bug33106.sandboxes.ptfs-europe.co.uk (In reply to Jonathan Druart from comment #6) > I've asked Martin to create a sandbox and I did recreate the problem there. > After we rebuilt the JS file it's now working: > http://staff-bug33106.sandboxes.ptfs-europe.co.uk I've opened https://gitlab.com/koha-community/koha-sandboxes-docker/-/issues/88 Created attachment 148944 [details] [review] Bug 33106: Add vendor link to ERM licenses This patch adds a "Licenses" link in the acquisition module to link to the licenses defined in the ERM module. Test plan: - Create a vendor - Create some licenses in the ERM module, add some to the vendor previously created - Go to the detail page of the vendor in the acquisition module => Notice the new "Licenses" tab on the side bar => Notice that this tab does not appear if you do not have the permission to see licenses - Click on the new tab => Notice that you are redirected to the license list view, in the ERM module, with an automatic filter on the vendor Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com> That works now, thanks for fixing that! I still think it would be good to not display the link if there is no attached record but I think we can deal with that in a separate bugzilla entry, this works as planned. Created attachment 148946 [details] [review] Bug 33106: Add vendor link to ERM licenses This patch adds a "Licenses" link in the acquisition module to link to the licenses defined in the ERM module. Test plan: - Create a vendor - Create some licenses in the ERM module, add some to the vendor previously created - Go to the detail page of the vendor in the acquisition module => Notice the new "Licenses" tab on the side bar => Notice that this tab does not appear if you do not have the permission to see licenses - Click on the new tab => Notice that you are redirected to the license list view, in the ERM module, with an automatic filter on the vendor Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com> (In reply to Jonathan Field from comment #9) > That works now, thanks for fixing that! I still think it would be good to > not display the link if there is no attached record but I think we can deal > with that in a separate bugzilla entry, this works as planned. I am not sure about that. The other tabs are there even if there is nothing on the view (for baskets). If we add another tab later (for issues for instance), it will be placed differently depending on the existence of license linked to the vendor, that does not seem correct to me. We could add the number of licenses in parenthesis but again, it is inconsistent with the other tabs. So basically, yes, we should discuss that on a separate bug :) (In reply to Jonathan Druart from comment #11) > (In reply to Jonathan Field from comment #9) > > That works now, thanks for fixing that! I still think it would be good to > > not display the link if there is no attached record but I think we can deal > > with that in a separate bugzilla entry, this works as planned. > > I am not sure about that. The other tabs are there even if there is nothing > on the view (for baskets). If we add another tab later (for issues for > instance), it will be placed differently depending on the existence of > license linked to the vendor, that does not seem correct to me. > > We could add the number of licenses in parenthesis but again, it is > inconsistent with the other tabs. > > So basically, yes, we should discuss that on a separate bug :) I agree about the separate bug, so I filed it: Bug 33465 - Make it clear if there are linked licenses when viewing the vendor record I also agree that we should make it visible somehow if there are even licenses linked. Either by not displaying the tab or by showing the number of licenses link in the tab label. Created attachment 149371 [details] [review] Bug 33106: Add vendor link to ERM licenses This patch adds a "Licenses" link in the acquisition module to link to the licenses defined in the ERM module. Test plan: - Create a vendor - Create some licenses in the ERM module, add some to the vendor previously created - Go to the detail page of the vendor in the acquisition module => Notice the new "Licenses" tab on the side bar => Notice that this tab does not appear if you do not have the permission to see licenses - Click on the new tab => Notice that you are redirected to the license list view, in the ERM module, with an automatic filter on the vendor Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> |