Bug 33127

Summary: Use template wrapper for breadcrumbs: Administration part 5
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Katrin Fischer <katrin.fischer>
Severity: enhancement    
Priority: P5 - low CC: andrew.auld, testopia, tomascohen
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Small patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.06
Circulation function:
Bug Depends on: 32507    
Bug Blocks:    
Attachments: Bug 33127: Use template wrapper for breadcrumbs: Administration part 5
Bug 33127: Use template wrapper for breadcrumbs: Administration part 5
Bug 33127: Use template wrapper for breadcrumbs: Administration part 5
Bug 33127: Use template wrapper for breadcrumbs: Administration part 5
Bug 33127: Use template wrapper for breadcrumbs: Administration part 5
Bug 33127: Use template wrapper for breadcrumbs: Administration part 5

Description Owen Leonard 2023-03-03 14:05:11 UTC
To continue the process started by Bug 32507, this patch will update several more templates in administration so that they use the new template wrapper for breadcrumbs.

- marc-overlay-rules.tt
- marctagstructure.tt
- matching-rules.tt
- oai_set_mappings.tt
- oai_sets.tt
- overdrive.tt
- patron-attr-types.tt
- preferences.tt
- restrictions.tt
- search_filters.tt
Comment 1 Owen Leonard 2023-03-03 15:31:35 UTC Comment hidden (obsolete)
Comment 2 Biblibre Sandboxes 2023-03-28 14:55:05 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2023-04-08 22:32:44 UTC Comment hidden (obsolete)
Comment 4 Owen Leonard 2023-04-17 13:34:58 UTC
Created attachment 149756 [details] [review]
Bug 33127: Use template wrapper for breadcrumbs: Administration part 5

This patch updates several administration templates so that they
use the new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

Administration ->
 - Record overlay rules
 - Search filters (must have SavedSearchFilters enabled)
 - System preferences
   -> OverDriveAuthName -> OverDrive library authnames table
 - MARC bibliographic framework -> MARC structure (list, new, edit,
   delete confirm).
 - Record matching rules (list, new, edit, delete confirm)
 - OAI sets configuration (list, new, edit)
   -> Define mappings
 - Patron attribute types (list, new, edit, delete confirm)
 - Patron restrictions (list, new, edit, delete confirm)
Comment 5 PTFS Europe Sandboxes 2023-04-19 09:26:19 UTC
Created attachment 149846 [details] [review]
Bug 33127: Use template wrapper for breadcrumbs: Administration part 5

This patch updates several administration templates so that they
use the new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

Administration ->
 - Record overlay rules
 - Search filters (must have SavedSearchFilters enabled)
 - System preferences
   -> OverDriveAuthName -> OverDrive library authnames table
 - MARC bibliographic framework -> MARC structure (list, new, edit,
   delete confirm).
 - Record matching rules (list, new, edit, delete confirm)
 - OAI sets configuration (list, new, edit)
   -> Define mappings
 - Patron attribute types (list, new, edit, delete confirm)
 - Patron restrictions (list, new, edit, delete confirm)

Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Comment 6 Andrew Auld 2023-04-19 09:30:51 UTC
Great. All looks good. I took a particularly deep dive around the Marc Structure and Marc overlay rules areas.
Comment 7 Katrin Fischer 2023-04-20 20:27:30 UTC
Created attachment 149987 [details] [review]
Bug 33127: Use template wrapper for breadcrumbs: Administration part 5

This patch updates several administration templates so that they
use the new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

Administration ->
 - Record overlay rules
 - Search filters (must have SavedSearchFilters enabled)
 - System preferences
   -> OverDriveAuthName -> OverDrive library authnames table
 - MARC bibliographic framework -> MARC structure (list, new, edit,
   delete confirm).
 - Record matching rules (list, new, edit, delete confirm)
 - OAI sets configuration (list, new, edit)
   -> Define mappings
 - Patron attribute types (list, new, edit, delete confirm)
 - Patron restrictions (list, new, edit, delete confirm)

Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 8 Tomás Cohen Arazi (tcohen) 2023-04-21 13:37:25 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 9 Jacob O'Mara 2023-05-10 12:54:34 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.