Summary: | Add Polish translations for language descriptions | ||
---|---|---|---|
Product: | Koha | Reporter: | Janusz Kaczmarek <januszop> |
Component: | Installation and upgrade (web-based installer) | Assignee: | Bugs List <koha-bugs> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | f.demians, gmcharlt, nick |
Version: | 22.11 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.06
|
|
Circulation function: | |||
Attachments: |
Bug 33128: Add Polish translations for language descriptions
Bug 33128: Add Polish translations for language descriptions Bug 33128: Add Polish translations for language descriptions Bug 33128: Add Polish translations for language descriptions Bug 33128: Add Polish translations for language descriptions |
Description
Janusz Kaczmarek
2023-03-03 15:04:21 UTC
Created attachment 147703 [details] [review] Bug 33128: Add Polish translations for language descriptions This adds the Polish translations for the different languages to subtag_registry.sql that is used by all languages during installation. Test plan: ========== * Apply patch * Run database update * Install pl-PL and activate it for the OPAC * Go to advanced search * Look at the language pull down - it shows the languages in their language and then translated to English * Switch to Polish - verify the Polish translations are used now There are 2-3 cases where the translation = name, so only name is shown. * Drop your database, create your database * Run the web installer * Everything should complete without error and the language pull down should look exactly the same and be translated [Test plan courtesy of Bug 31715 for German] Created attachment 148101 [details] [review] Bug 33128: Add Polish translations for language descriptions This adds the Polish translations for the different languages to subtag_registry.sql that is used by all languages during installation. Test plan: ========== * Apply patch * Run database update * Install pl-PL and activate it for the OPAC * Go to advanced search * Look at the language pull down - it shows the languages in their language and then translated to English * Switch to Polish - verify the Polish translations are used now There are 2-3 cases where the translation = name, so only name is shown. * Drop your database, create your database * Run the web installer * Everything should complete without error and the language pull down should look exactly the same and be translated [Test plan courtesy of Bug 31715 for German] The update works well, but installing fresh failed. It looks like a bad copy paste here: installer/data/mysql/mandatory/subtag_registry.sql All the lines like: INSERT INTO language_subtag_registry( subtag, type, description, added) Should be: INSERT INTO language_descriptions(subtag, type, lang, description) (In reply to Nick Clemens from comment #3) > The update works well, but installing fresh failed. > > > It looks like a bad copy paste here: > installer/data/mysql/mandatory/subtag_registry.sql > > All the lines like: > INSERT INTO language_subtag_registry( subtag, type, description, added) > > Should be: > INSERT INTO language_descriptions(subtag, type, lang, description) What a shame--indeed. Correction follows. Created attachment 149781 [details] [review] Bug 33128: Add Polish translations for language descriptions This adds the Polish translations for the different languages to subtag_registry.sql that is used by all languages during installation. Test plan: ========== * Apply patch * Run database update * Install pl-PL and activate it for the OPAC * Go to advanced search * Look at the language pull down - it shows the languages in their language and then translated to English * Switch to Polish - verify the Polish translations are used now There are 2-3 cases where the translation = name, so only name is shown. * Drop your database, create your database * Run the web installer * Everything should complete without error and the language pull down should look exactly the same and be translated [Test plan courtesy of Bug 31715 for German] Created attachment 149833 [details] [review] Bug 33128: Add Polish translations for language descriptions This adds the Polish translations for the different languages to subtag_registry.sql that is used by all languages during installation. * Apply patch * Run database update * Install pl-PL and activate it for the OPAC * Go to advanced search * Look at the language pull down - it shows the languages in their language and then translated to English * Switch to Polish - verify the Polish translations are used now There are 2-3 cases where the translation = name, so only name is shown. * Drop your database, create your database * Run the web installer * Everything should complete without error and the language pull down should look exactly the same and be translated Signed-off-by: Nick <nick@bywatersolutions.com> Created attachment 150082 [details] [review] Bug 33128: Add Polish translations for language descriptions This adds the Polish translations for the different languages to subtag_registry.sql that is used by all languages during installation. * Apply patch * Run database update * Install pl-PL and activate it for the OPAC * Go to advanced search * Look at the language pull down - it shows the languages in their language and then translated to English * Switch to Polish - verify the Polish translations are used now There are 2-3 cases where the translation = name, so only name is shown. * Drop your database, create your database * Run the web installer * Everything should complete without error and the language pull down should look exactly the same and be translated Signed-off-by: Nick <nick@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Ultimately, we should do better with the way we manage these, but for now, this is all good :) Pushed to master for 23.05. Nice work everyone, thanks! Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release |