Summary: | Use template wrapper for breadcrumbs: Administration part 6 | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | RESOLVED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | normal | ||
Priority: | P5 - low | CC: | andrew.auld, martin.renvoize, testopia |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.05
|
|
Circulation function: | |||
Bug Depends on: | 32507 | ||
Bug Blocks: | |||
Attachments: |
Bug 33129: Use template wrapper for breadcrumbs: Administration part 6
Bug 33129: Use template wrapper for breadcrumbs: Administration part 6 Bug 33129: Use template wrapper for breadcrumbs: Administration part 6 |
Description
Owen Leonard
2023-03-03 15:55:05 UTC
Created attachment 147719 [details] [review] Bug 33129: Use template wrapper for breadcrumbs: Administration part 6 This patch updates several administration templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. Administration -> - Search engine configuration (Elasticsearch) - Share content with Mana KB - Circulation and fine rules - SMS cellular providers (SMSSendDriver preference must be set) - System preferences -> Local use (list, add, edit, confirm delete) - Library transfer limits (Advanced editor) - Transport cost matrix - Usage statistics - Z39.50/SRU servers administration (list, add, edit, both Z39.50 and SRU servers) In testing this, everything works as it should. However, for the SMS cellular providers, when I click 'New SMS Provider' the breadcrumb doesn't add another crumb 'New SMS Provider'. This means that I can't easily use the breadcrumb to go back to the SMS Provider list page. Similarly, when I edit an SMS Provider that I have added, the breadcrumb also doesn't add another crumb eg 'Modify SMS Provider <SMS Provider name>'. Again, this makes it difficult to exit the edit page back to the list page using the breadcrumb links. I am not sure whether this should be fixed as part of this bug or added as a new bug. (In reply to Andrew Auld from comment #2) > However, for the SMS cellular providers, when I click 'New SMS Provider' the > breadcrumb doesn't add another crumb 'New SMS Provider' Since the behavior you describe is in master as well I would prefer that this be addressed in another bug. Currently we don't have an established method of updating elements like breadcrumbs and page titles when the content of the page changes without a page reload Created attachment 148920 [details] [review] Bug 33129: Use template wrapper for breadcrumbs: Administration part 6 This patch updates several administration templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. Administration -> - Search engine configuration (Elasticsearch) - Share content with Mana KB - Circulation and fine rules - SMS cellular providers (SMSSendDriver preference must be set) - System preferences -> Local use (list, add, edit, confirm delete) - Library transfer limits (Advanced editor) - Transport cost matrix - Usage statistics - Z39.50/SRU servers administration (list, add, edit, both Z39.50 and SRU servers) Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com> OK I have signed this off and reached out to Martin to help me create a bug relating to the SMS breadcrumb thing. Created attachment 149330 [details] [review] Bug 33129: Use template wrapper for breadcrumbs: Administration part 6 This patch updates several administration templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. Administration -> - Search engine configuration (Elasticsearch) - Share content with Mana KB - Circulation and fine rules - SMS cellular providers (SMSSendDriver preference must be set) - System preferences -> Local use (list, add, edit, confirm delete) - Library transfer limits (Advanced editor) - Transport cost matrix - Usage statistics - Z39.50/SRU servers administration (list, add, edit, both Z39.50 and SRU servers) Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.05. Nice work everyone, thanks! Nice work everyone! Pushed to stable for 22.11.x |