Bug 33131

Summary:	Use template wrapper for breadcrumbs: Catalog part 1
Product:	Koha	Reporter:	Owen Leonard <oleonard>
Component:	Templates	Assignee:	Owen Leonard <oleonard>
Status:	RESOLVED FIXED	QA Contact:	Testopia <testopia>
Severity:	minor
Priority:	P5 - low	CC:	andrew.auld, jacob.omara, testopia
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Small patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	23.05.00,22.11.05
Circulation function:
Bug Depends on:	32507
Bug Blocks:	33460
Attachments:	Bug 33131: Use template wrapper for breadcrumbs: Catalog part 1 Bug 33131: Use template wrapper for breadcrumbs: Catalog part 1 Bug 33131: Use template wrapper for breadcrumbs: Catalog part 1

Description Owen Leonard 2023-03-03 18:52:56 UTC

To continue the process started by Bug 32507, this patch will update several catalog templates so that they use the new template wrapper for breadcrumbs.

 - catalogue/advsearch.tt
 - catalogue/detail.tt
 - catalogue/imageviewer.tt
 - catalogue/ISBDdetail.tt
 - catalogue/issuehistory.tt
 - catalogue/itemsearch.tt
 - catalogue/labeledMARCdetail.tt
 - catalogue/MARCdetail.tt
 - catalogue/moredetail.tt
 - catalogue/results.tt

Comment 1 Owen Leonard 2023-03-03 19:18:40 UTC

Created attachment 147728 [details] [review]
Bug 33131: Use template wrapper for breadcrumbs: Catalog part 1

This patch updates several catalog templates so that they use the new
WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Advanced search
- Bibliographic detail page
- Labeled MARC detail page
- MARC detail page
- ISBD detail page
- Item detail page
- Image detail view (with LocalCoverImages enabled and a custom cover
  added)
- Checkout history
- Item search

Comment 2 PTFS Europe Sandboxes 2023-03-29 09:24:50 UTC

Created attachment 148893 [details] [review]
Bug 33131: Use template wrapper for breadcrumbs: Catalog part 1

This patch updates several catalog templates so that they use the new
WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Advanced search
- Bibliographic detail page
- Labeled MARC detail page
- MARC detail page
- ISBD detail page
- Item detail page
- Image detail view (with LocalCoverImages enabled and a custom cover
  added)
- Checkout history
- Item search

Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>

Comment 3 Katrin Fischer 2023-04-08 22:19:24 UTC

Created attachment 149328 [details] [review]
Bug 33131: Use template wrapper for breadcrumbs: Catalog part 1

This patch updates several catalog templates so that they use the new
WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Advanced search
- Bibliographic detail page
- Labeled MARC detail page
- MARC detail page
- ISBD detail page
- Item detail page
- Image detail view (with LocalCoverImages enabled and a custom cover
  added)
- Checkout history
- Item search

Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Comment 4 Tomás Cohen Arazi (tcohen) 2023-04-12 14:22:47 UTC

Pushed to master for 23.05.

Nice work everyone, thanks!

Comment 5 Jacob O'Mara 2023-04-16 20:46:09 UTC

Nice work, thanks everyone!

Pushed to 22.11.x for the next release.