| Summary: | Use facet label value in mouseover title attribute of facet removal link | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Andreas Jonsson <andreas.jonsson> |
| Component: | Searching | Assignee: | Andreas Jonsson <andreas.jonsson> |
| Status: | RESOLVED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | fridolin.somers, lucas |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33139 | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.11.00,23.05.03,22.11.09
|
|
| Circulation function: | |||
| Attachments: |
Bug 33140 Use facet label value for mouseover text on facet removal link
Bug 33140: Use facet label value for mouseover text on facet removal link Bug 33140: Use facet label value for mouseover text on facet removal link |
||
|
Description
Andreas Jonsson
2023-03-05 12:19:36 UTC
Created attachment 147773 [details] [review] Bug 33140 Use facet label value for mouseover text on facet removal link Test plan: * Follow the test plan in bug 33139 but additionally add this patch * Observe the mouseover text when hovering over the facet removal button of the E-resource facet (without patch the text will be "remove facet true/false") Andreas, This one also looks like a good patch but lacks the proper commit message: * Commit title does not start with 'Bug XXXXX: ' - 224750a113 If you can fix this I would be happy to sign-off. Created attachment 153927 [details] [review] Bug 33140: Use facet label value for mouseover text on facet removal link This patch updates the facets includes in both the staff interface and OPAC so that the title attribute on "remove" links uses the full name rather than the code of the facet. So, library name instead of branchcode, collection code description instead of authorized value code. To test, apply the patch and perform a search in the staff interface. - Click a facet in the left-hand sidebar which will return more than one result. - On the reloaded page there should be a link next to that facet: [X]. Hovering your mouse over it should show "Remove facet [facet name]" e.g. "Remove facet Centerville" instead of "Remove facet CPL" - Test on library facets, item type facets, and collection code facets. - Perform the same test in the OPAC. Signed-off-by: Owen Leonard <oleonard@myacpl.org> I corrected the commit message and added the test plan. Everything worked as it should in my tests. Created attachment 154056 [details] [review] Bug 33140: Use facet label value for mouseover text on facet removal link This patch updates the facets includes in both the staff interface and OPAC so that the title attribute on "remove" links uses the full name rather than the code of the facet. So, library name instead of branchcode, collection code description instead of authorized value code. To test, apply the patch and perform a search in the staff interface. - Click a facet in the left-hand sidebar which will return more than one result. - On the reloaded page there should be a link next to that facet: [X]. Hovering your mouse over it should show "Remove facet [facet name]" e.g. "Remove facet Centerville" instead of "Remove facet CPL" - Test on library facets, item type facets, and collection code facets. - Perform the same test in the OPAC. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.11. Nice work everyone, thanks! Pushed to 23.05.x for 23.05.03 Nice work everyone! Pushed to 22.11.x for next release |