Bug 33148

Summary:	Use template wrapper for breadcrumbs: Cataloging
Product:	Koha	Reporter:	Owen Leonard <oleonard>
Component:	Templates	Assignee:	Owen Leonard <oleonard>
Status:	CLOSED FIXED	QA Contact:	Nick Clemens (kidclamp) <nick>
Severity:	minor
Priority:	P5 - low	CC:	clemens.tubach, lucas, nick, testopia
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Small patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	23.05.00,22.11.05
Circulation function:
Bug Depends on:	32507
Bug Blocks:
Attachments:	Bug 33148: Use template wrapper for breadcrumbs: Cataloging Bug 33148: Use template wrapper for breadcrumbs: Cataloging Bug 33148: Use template wrapper for breadcrumbs: Cataloging

Description Owen Leonard 2023-03-06 14:49:10 UTC

To continue the process started by Bug 32507, this patch will update cataloging templates so that they use the new template wrapper for breadcrumbs.

 - cataloguing/addbiblio.tt
 - cataloguing/addbooks.tt
 - cataloguing/additem.tt
 - cataloguing/cataloging-home.tt
 - cataloguing/editor.tt
 - cataloguing/linkitem.tt
 - cataloguing/merge.tt
 - cataloguing/moveitem.tt

Comment 1 Owen Leonard 2023-03-06 14:59:22 UTC

Created attachment 147791 [details] [review]
Bug 33148: Use template wrapper for breadcrumbs: Cataloging

This patch updates several cataloging templates so that they use the new
WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Cataloging -> Home page
  - Cataloging search results
    - Select two results and 'Merge selected'
  - Basic MARC editor
  - Advanced MARC editor
  - Item edit page
 - Catalog -> Search -> Bibliographic record details
   - Edit -> Attach item
   - Edit -> Link to host record (must have EasyAnalyticalRecords
     preference enabled)

Comment 2 Lucas Gass (lukeg) 2023-03-16 21:04:22 UTC

I have one comment regarding the advanced editor vs basic edtior:

New record in the basic editor:

 -Cataloging > Add MARC record 

New record in the advanced editor:

 -Cataloging > Editor 

Existing record in the basic editor:

 -Cataloging > CSS : the definitive guide / Eric A. Meyer. (Record number 12) 

Existing record in the advanced editor:

 -Cataloging > Editor 


Should these made to match? And if so should we do it here or in a different bug?

Comment 3 Clemens Tubach 2023-03-29 08:42:42 UTC

Created attachment 148883 [details] [review]
Bug 33148: Use template wrapper for breadcrumbs: Cataloging

This patch updates several cataloging templates so that they use the new
WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Cataloging -> Home page
  - Cataloging search results
    - Select two results and 'Merge selected'
  - Basic MARC editor
  - Advanced MARC editor
  - Item edit page
 - Catalog -> Search -> Bibliographic record details
   - Edit -> Attach item
   - Edit -> Link to host record (must have EasyAnalyticalRecords
     preference enabled)

Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu>

Comment 4 Nick Clemens (kidclamp) 2023-04-01 22:59:16 UTC

Created attachment 149070 [details] [review]
Bug 33148: Use template wrapper for breadcrumbs: Cataloging

This patch updates several cataloging templates so that they use the new
WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Cataloging -> Home page
  - Cataloging search results
    - Select two results and 'Merge selected'
  - Basic MARC editor
  - Advanced MARC editor
  - Item edit page
 - Catalog -> Search -> Bibliographic record details
   - Edit -> Attach item
   - Edit -> Link to host record (must have EasyAnalyticalRecords
     preference enabled)

Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Comment 5 Nick Clemens (kidclamp) 2023-04-01 23:00:10 UTC

(In reply to Lucas Gass from comment #2)
> I have one comment regarding the advanced editor vs basic edtior:
> 
> New record in the basic editor:
>  -Cataloging > Add MARC record 
> 
> New record in the advanced editor:
>  -Cataloging > Editor 
> 
> Existing record in the basic editor:
>  -Cataloging > CSS : the definitive guide / Eric A. Meyer. (Record number
> 12) 
> 
> Existing record in the advanced editor:
>  -Cataloging > Editor 
> Should these made to match? And if so should we do it here or in a different
> bug?

Yes, please file a new bug, these seem to exist before these patches

Comment 6 Tomás Cohen Arazi (tcohen) 2023-04-06 12:30:29 UTC

Pushed to master for 23.05.

Nice work everyone, thanks!

Comment 7 Jacob O'Mara 2023-04-16 17:24:33 UTC

Nice work, thanks everyone!

Pushed to 22.11.x for the next release.