Summary: | Improve translation of strings in cities and circulation desk administration pages | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | I18N/L10N | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | arthur.suzuki, f.demians, lucas, martin.renvoize |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.04,22.05.12, 21.11.20
|
|
Circulation function: | |||
Attachments: |
Bug 33151: Improve translation of string in cities.tt and desks.tt
Bug 33151: Improve translation of string in cities.tt and desks.tt Bug 33151: Improve translation of string in cities.tt and desks.tt |
Description
Owen Leonard
2023-03-06 18:01:16 UTC
Created attachment 147796 [details] [review] Bug 33151: Improve translation of string in cities.tt and desks.tt This patch adds a <span> tag around a string in both cities.tt and desks.tt in order to improve translatability. To test apply the patch and run the translation script to update the .po files, e.g. perl misc/translator/translate update fr-FR Check the updated .po files: - Before the patch you would have found 'msgid "%s Searching: %s %s %s' - After the patch you should find 'msgid "Searching: %s' Created attachment 147900 [details] [review] Bug 33151: Improve translation of string in cities.tt and desks.tt This patch adds a <span> tag around a string in both cities.tt and desks.tt in order to improve translatability. To test apply the patch and run the translation script to update the .po files, e.g. perl misc/translator/translate update fr-FR Check the updated .po files: - Before the patch you would have found 'msgid "%s Searching: %s %s %s' - After the patch you should find 'msgid "Searching: %s' Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Created attachment 148235 [details] [review] Bug 33151: Improve translation of string in cities.tt and desks.tt This patch adds a <span> tag around a string in both cities.tt and desks.tt in order to improve translatability. To test apply the patch and run the translation script to update the .po files, e.g. perl misc/translator/translate update fr-FR Check the updated .po files: - Before the patch you would have found 'msgid "%s Searching: %s %s %s' - After the patch you should find 'msgid "Searching: %s' Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Breaking the rules a little here, QAing a patch one of my team signed off on.. But it's a trivial and clear improvement so I think we're safe.. I'll leave it to the RM to push back if he wants a further QA ;P Passing QA I am all ok with that :)(In reply to Martin Renvoize from comment #4) > Breaking the rules a little here, QAing a patch one of my team signed off > on.. But it's a trivial and clear improvement so I think we're safe.. I'll > leave it to the RM to push back if he wants a further QA ;P > > Passing QA You got the QAM's ok there :) Pushed to master for 23.05. Nice work everyone, thanks! Nice work everyone! Pushed to stable for 22.11.x Backported to 22.05.x for upcoming 22.05.12 applied to 21.11.x for 21.11.20 |