Bug 33160

Created attachment 147867 [details] [review]
Bug 33160: Use hostinfo to display title information when 773$w is empty

When a 773 entry is not linked to another record using 773$w or
by using Easyanalytics, the title information would not display.

To test:
1. Activate the UseControlNumber system preference
2. Search for a record and make sure it has 001 set to some value.
3. Use Edit > Add child record to create an analytical record from this record.
4. Make sure 773$w was filled in and finish by adding any mandatory fields, save.
5. Add this record to your cart. Also add a 773$g with the pages or similar.
6. Create another record with 773$t and $g, but without $w.
7. Also add this record to your cart.
8. Look at the cart brief and full view in staff and OPAC.
9. Verify the In: source information only displays for the first record.
10. Apply patch
11. Veriy the In: source information now displays for both records on all 4 pages.

It works!  Step 3 had to be a little different, because there's no "Edit > Add child record"--one has to "New > New child record."  Also, between step 4 & 5 one has to edit the defaul framework to make 773 $g visible in the editor.

Cheerio!
--h2

QAing

Looking at what happened in get_marc_host, I must say that the POD has not been fully updated and that the unit test does not even include this new hostinfo return. Thats really bad to pass thru QA.

+    my ( $host, $relatedparts, $hostinfo ) = $biblio->get_marc_host;
     $dat->{HOSTITEMENTRIES} = $host;

HOSTITEMENTRIES is quite obscure name for a Koha::Biblio object !

basket.tt

-                                            [% IF BIBLIO_RESULT.HOSTITEMENTRIES %]
+                                            [% IF BIBLIO_RESULT.HOSTITEMENTRIES || BIBLIO_RESULT.HOSTINFO %]
                                                 <p>In:
                                                 [% IF BIBLIO_RESULT.HOSTITEMENTRIES.biblionumber %]

The change in the condition makes the next condition vulnerable. Since HOSTITEMENTRIES could be undefined now.

Same here
@@ -244,7 +244,7 @@
                                                         [% IF BIBLIO_RESULT.HOSTITEMENTRIES.biblionumber %]

Created attachment 148639 [details] [review]
Bug 33160: Use hostinfo to display title information when 773$w is empty

When a 773 entry is not linked to another record using 773$w or
by using Easyanalytics, the title information would not display.

To test:
1. Activate the UseControlNumber system preference
2. Search for a record and make sure it has 001 set to some value.
3. Use Edit > Add child record to create an analytical record from this record.
4. Make sure 773$w was filled in and finish by adding any mandatory fields, save.
5. Add this record to your cart. Also add a 773$g with the pages or similar.
6. Create another record with 773$t and $g, but without $w.
7. Also add this record to your cart.
8. Look at the cart brief and full view in staff and OPAC.
9. Verify the In: source information only displays for the first record.
10. Apply patch
11. Veriy the In: source information now displays for both records on all 4 pages.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Created attachment 148640 [details] [review]
Bug 33160: (QA follow-up) Adjust condition on biblio object

If it is undefined, there is no biblionumber.
If it is, we can safely assume that it has a biblionumber. Which
is the case for most biblio records, lol.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Please open a new report for slight POD adjustments and testing hostinfo.

(In reply to Heather from comment #2)
> It works!  Step 3 had to be a little different, because there's no "Edit >
> Add child record"--one has to "New > New child record."  Also, between step
> 4 & 5 one has to edit the defaul framework to make 773 $g visible in the
> editor.
> 
> Cheerio!
> --h2

You forgot a so line. Will add it now.

Created attachment 148641 [details] [review]
Bug 33160: Use hostinfo to display title information when 773$w is empty

When a 773 entry is not linked to another record using 773$w or
by using Easyanalytics, the title information would not display.

To test:
1. Activate the UseControlNumber system preference
2. Search for a record and make sure it has 001 set to some value.
3. Use Edit > Add child record to create an analytical record from this record.
4. Make sure 773$w was filled in and finish by adding any mandatory fields, save.
5. Add this record to your cart. Also add a 773$g with the pages or similar.
6. Create another record with 773$t and $g, but without $w.
7. Also add this record to your cart.
8. Look at the cart brief and full view in staff and OPAC.
9. Verify the In: source information only displays for the first record.
10. Apply patch
11. Veriy the In: source information now displays for both records on all 4 pages.

Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Created attachment 148642 [details] [review]
Bug 33160: (QA follow-up) Adjust condition on biblio object

If it is undefined, there is no biblionumber.
If it is, we can safely assume that it has a biblionumber. Which
is the case for most biblio records, lol.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

> You forgot a so line. Will add it now.

Thank you, Marcel!  I'm still very much at newbie at this!
--h2

Pushed to master for 23.05.

Nice work everyone, thanks!

Nice work, thanks everyone!

Pushed to 22.11.x for the next release.

(In reply to Jacob O'Mara from comment #16)
> Nice work, thanks everyone!
> 
> Pushed to 22.11.x for the next release.

Hi Jacob, the dependency is not in 22.11 - not sure if this can work.

Hi Katrin, sorry this message slipped through my radar!!! 

I could be being really very stupid but was the dependency not pushed in 22.11.03?

I'm probably missing something really obvious!

Missing dependencies for 22.05.x, no backport.