Bug 33181

Summary: Use template wrapper for tabs on record merge pages
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: RESOLVED FIXED QA Contact: Katrin Fischer <katrin.fischer>
Severity: normal    
Priority: P5 - low CC: andrew.auld, lucas, martin.renvoize, testopia
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.05
Bug Depends on: 32571, 33278    
Bug Blocks:    
Attachments: Bug 33181: Use template wrapper for tabs on record merge pages
Bug 33181: Use template wrapper for tabs on record merge pages
Bug 33181: Use template wrapper for tabs on record merge pages
Bug 33181: Use template wrapper for tabs on record merge pages

Description Owen Leonard 2023-03-09 15:42:28 UTC
Continuing the work of Bug 32571, the biblio and authority merge pages should be updated to use the new WRAPPER for tabs.
Comment 1 Owen Leonard 2023-03-09 15:52:37 UTC Comment hidden (obsolete)
Comment 2 Lucas Gass 2023-03-16 12:53:29 UTC
Owen, can this one be rebased?
Comment 3 Owen Leonard 2023-03-21 17:19:59 UTC
Created attachment 148488 [details] [review]
Bug 33181: Use template wrapper for tabs on record merge pages

This patch updates the include file which is used by both the
bibliographic and authority recrd merge pages. The markup is updated to
use the new tab WRAPPER directives.

To test, apply the patch and perform a catalog search which will return
more than one record.

 - Select two or more records and choose "Merge records" from the edit
   menu at the top of the search results.
 - On the following page you should see one tab for each record you
   selected from the search results.
 - Clicking each tab should show you the correct bibliographic details.

Perform the same tests from the authority search results page.
Comment 4 Biblibre Sandboxes 2023-03-29 12:37:31 UTC
Created attachment 148912 [details] [review]
Bug 33181: Use template wrapper for tabs on record merge pages

This patch updates the include file which is used by both the
bibliographic and authority recrd merge pages. The markup is updated to
use the new tab WRAPPER directives.

To test, apply the patch and perform a catalog search which will return
more than one record.

 - Select two or more records and choose "Merge records" from the edit
   menu at the top of the search results.
 - On the following page you should see one tab for each record you
   selected from the search results.
 - Clicking each tab should show you the correct bibliographic details.

Perform the same tests from the authority search results page.

Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Comment 5 Katrin Fischer 2023-04-08 22:00:37 UTC
Created attachment 149324 [details] [review]
Bug 33181: Use template wrapper for tabs on record merge pages

This patch updates the include file which is used by both the
bibliographic and authority recrd merge pages. The markup is updated to
use the new tab WRAPPER directives.

To test, apply the patch and perform a catalog search which will return
more than one record.

 - Select two or more records and choose "Merge records" from the edit
   menu at the top of the search results.
 - On the following page you should see one tab for each record you
   selected from the search results.
 - Clicking each tab should show you the correct bibliographic details.

Perform the same tests from the authority search results page.

Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Tomás Cohen Arazi 2023-04-14 18:39:16 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 7 Matt Blenkinsop 2023-04-18 12:19:52 UTC
Nice work everyone!

Pushed to stable for 22.11.x